Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-17 Thread Arnd Bergmann
On Wed, May 17, 2017 at 2:17 PM, Tom Psyborg wrote: > > > On 16 May 2017 at 16:31, Jes Sorensen wrote: >> >> >> True - if the automatic conversion works without automatic intervention, I >> am less worried about it. Personally I would still focus on converting one >> function at a time to reduce

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread David Miller
From: Johannes Berg Date: Tue, 16 May 2017 13:58:56 +0200 > On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote: >> >> In rt2x00 driver we use poor convention in other kind of registers >> accessors like bbp, mac, eeprom. I dislike to changing only rfcsr >> accessors and leaving others in

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Arnd Bergmann
On Tue, May 16, 2017 at 4:23 PM, Stanislaw Gruszka wrote: > On Tue, May 16, 2017 at 01:55:17PM +0200, Stanislaw Gruszka wrote: >> On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: >> > From: Stanislaw Gruszka >> > Date: Mon, 15 May 2017 16:28:01 +0200 >> > >> > > On Mon, May 15, 2017

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Jes Sorensen
On 05/16/2017 10:19 AM, Arnd Bergmann wrote: On Tue, May 16, 2017 at 3:44 PM, Jes Sorensen wrote: On 05/16/2017 07:55 AM, Stanislaw Gruszka wrote: On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: Passing return values by reference is and always has been a really poor way to ach

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Stanislaw Gruszka
On Tue, May 16, 2017 at 01:55:17PM +0200, Stanislaw Gruszka wrote: > On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: > > From: Stanislaw Gruszka > > Date: Mon, 15 May 2017 16:28:01 +0200 > > > > > On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: > > >> With CONFIG_KASA

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Arnd Bergmann
On Tue, May 16, 2017 at 3:44 PM, Jes Sorensen wrote: > On 05/16/2017 07:55 AM, Stanislaw Gruszka wrote: >> >> On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: >>> >>> Passing return values by reference is and always has been a really >>> poor way to achieve what these functions are do

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Jes Sorensen
On 05/16/2017 07:55 AM, Stanislaw Gruszka wrote: On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: Passing return values by reference is and always has been a really poor way to achieve what these functions are doing. And frankly, whilst the tool could see what's going on here bette

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Stanislaw Gruszka
On Tue, May 16, 2017 at 01:58:56PM +0200, Johannes Berg wrote: > On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote: > > > > In rt2x00 driver we use poor convention in other kind of registers > > accessors like bbp, mac, eeprom. I dislike to changing only rfcsr > > accessors and leaving ot

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Johannes Berg
On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote: > > In rt2x00 driver we use poor convention in other kind of registers > accessors like bbp, mac, eeprom. I dislike to changing only rfcsr > accessors and leaving others in the old way. And changing all > accessors would be massive and er

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Stanislaw Gruszka
On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: > From: Stanislaw Gruszka > Date: Mon, 15 May 2017 16:28:01 +0200 > > > On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: > >> With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high > >> stack usage (with

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-15 Thread Daniel Golle
On Mon, May 15, 2017 at 10:40:52AM -0400, David Miller wrote: > From: Arnd Bergmann > Date: Mon, 15 May 2017 16:36:45 +0200 > > > On Mon, May 15, 2017 at 4:28 PM, Stanislaw Gruszka > > wrote: > >> On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: > >>> With CONFIG_KASAN enabled and

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-15 Thread David Miller
From: Arnd Bergmann Date: Mon, 15 May 2017 16:36:45 +0200 > On Mon, May 15, 2017 at 4:28 PM, Stanislaw Gruszka > wrote: >> On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: >>> With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high >>> stack usage (with a private p

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-15 Thread David Miller
From: Stanislaw Gruszka Date: Mon, 15 May 2017 16:28:01 +0200 > On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: >> With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high >> stack usage (with a private patch set I have to turn on this warning, >> which I intend to g

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-15 Thread Arnd Bergmann
On Mon, May 15, 2017 at 4:28 PM, Stanislaw Gruszka wrote: > On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: >> With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high >> stack usage (with a private patch set I have to turn on this warning, >> which I intend to get in

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-15 Thread Stanislaw Gruszka
On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: > With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high > stack usage (with a private patch set I have to turn on this warning, > which I intend to get into the next kernel release): > > wireless/ralink/rt2x00/rt2800l

[PATCH] rt2x00: improve calling conventions for register accessors

2017-05-15 Thread Arnd Bergmann
With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high stack usage (with a private patch set I have to turn on this warning, which I intend to get into the next kernel release): wireless/ralink/rt2x00/rt2800lib.c: In function 'rt2800_bw_filter_calibration': wireless/ralink/rt2x00/