Re: [PATCH] reorganize include/linux/dccp.h

2005-08-07 Thread Arnaldo Carvalho de Melo
On 8/7/05, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > Em Sun, Aug 07, 2005 at 04:59:27PM +0200, Harald Welte escreveu: > > On Sun, Aug 07, 2005 at 04:13:16AM -0300, Arnaldo Carvalho de Melo wrote: > > > > you cannot include linux/in.h from the top of the file, I think I tried > > > > tha

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-07 Thread Arnaldo Carvalho de Melo
Em Sun, Aug 07, 2005 at 04:59:27PM +0200, Harald Welte escreveu: > On Sun, Aug 07, 2005 at 04:13:16AM -0300, Arnaldo Carvalho de Melo wrote: > > > you cannot include linux/in.h from the top of the file, I think I tried > > > that and ran into problems (the definitions collide with glibc > > > defin

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-07 Thread Harald Welte
On Sun, Aug 07, 2005 at 04:13:16AM -0300, Arnaldo Carvalho de Melo wrote: > > you cannot include linux/in.h from the top of the file, I think I tried > > that and ran into problems (the definitions collide with glibc > > definitions e.g. of sockaddr_in, etc.) > > > > So if possible, move that incl

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-07 Thread Arnaldo Carvalho de Melo
Em Sun, Aug 07, 2005 at 08:58:34AM +0200, Harald Welte escreveu: > On Sat, Aug 06, 2005 at 06:34:40PM -0300, Arnaldo Carvalho de Melo wrote: > > On 8/6/05, Harald Welte <[EMAIL PROTECTED]> wrote: > > > Hi Arnaldo! > > > > > > The protocol header files in are usually structured in a > > > way to b

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-07 Thread Harald Welte
On Sat, Aug 06, 2005 at 06:34:40PM -0300, Arnaldo Carvalho de Melo wrote: > On 8/6/05, Harald Welte <[EMAIL PROTECTED]> wrote: > > Hi Arnaldo! > > > > The protocol header files in are usually structured in a > > way to be included by userspace code. The top section consists of > > general protoc

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-06 Thread Arnaldo Carvalho de Melo
On 8/6/05, Harald Welte <[EMAIL PROTECTED]> wrote: > Hi Arnaldo! > > The protocol header files in are usually structured in a > way to be included by userspace code. The top section consists of > general protocol structure definitions, typedefs, enums - followed by an > #ifdef __KERNEL__ section

[PATCH] reorganize include/linux/dccp.h

2005-08-06 Thread Harald Welte
Hi Arnaldo! The protocol header files in are usually structured in a way to be included by userspace code. The top section consists of general protocol structure definitions, typedefs, enums - followed by an #ifdef __KERNEL__ section. Currently doesn't follow that convention and can therefore