RE: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-13 Thread Hau
PATCH] r8169: default to 64-bit DMA on systems without memory > below 4 GB > > > On 12 May 2016 at 01:58, David Miller wrote: > > > From: Ard Biesheuvel > > > Date: Wed, 11 May 2016 09:47:49 +0200 > [...] > > > I think we should just seriously consider ch

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-12 Thread Francois Romieu
Francois Romieu : > Ard Biesheuvel : > > On 12 May 2016 at 16:09, Francois Romieu wrote: > [...] > > By resurrecting 353176888386, I mean the patch that changes the > > default for PCI express devices, so I think we are in agreement here ? > > Almost 353176888386: please modify it so that there

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-12 Thread Francois Romieu
Ard Biesheuvel : > On 12 May 2016 at 16:09, Francois Romieu wrote: [...] > By resurrecting 353176888386, I mean the patch that changes the > default for PCI express devices, so I think we are in agreement here ? Almost 353176888386: please modify it so that there's no change of behavior for mac_

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-12 Thread Ard Biesheuvel
On 12 May 2016 at 16:09, Francois Romieu wrote: >> On 12 May 2016 at 01:58, David Miller wrote: >> > From: Ard Biesheuvel >> > Date: Wed, 11 May 2016 09:47:49 +0200 > [...] >> > I think we should just seriously consider changing the default, it's >> > a really outdated reasoning behind the curre

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-12 Thread Francois Romieu
> On 12 May 2016 at 01:58, David Miller wrote: > > From: Ard Biesheuvel > > Date: Wed, 11 May 2016 09:47:49 +0200 [...] > > I think we should just seriously consider changing the default, it's > > a really outdated reasoning behind the current default setting. Maybe > > relevant a decade ago, bu

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-12 Thread Ard Biesheuvel
On 12 May 2016 at 01:58, David Miller wrote: > From: Ard Biesheuvel > Date: Wed, 11 May 2016 09:47:49 +0200 > >> The current logic around the 'use_dac' module parameter prevents the >> r81969 driver from being loadable on 64-bit systems without any RAM >> below 4 GB when the parameter is left at

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-11 Thread David Miller
From: Ard Biesheuvel Date: Wed, 11 May 2016 09:47:49 +0200 > The current logic around the 'use_dac' module parameter prevents the > r81969 driver from being loadable on 64-bit systems without any RAM > below 4 GB when the parameter is left at its default value. > So introduce a new default value

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-11 Thread Francois Romieu
Ard Biesheuvel : > On 11 May 2016 at 22:31, Francois Romieu wrote: [...] > It has little to do with f*cking legacy 32-bits-only-devices if DRAM > simply starts at 0x80__. This is on an AMD arm64 chip. The lack of IOMMU surprizes me. [...] > OK, if you prefer. Should I send a v2? Don't

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-11 Thread Ard Biesheuvel
On 11 May 2016 at 22:31, Francois Romieu wrote: > Ard Biesheuvel : >> The current logic around the 'use_dac' module parameter prevents the >> r81969 driver from being loadable on 64-bit systems without any RAM >> below 4 GB when the parameter is left at its default value. >> So introduce a new de

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-11 Thread Francois Romieu
Ard Biesheuvel : > The current logic around the 'use_dac' module parameter prevents the > r81969 driver from being loadable on 64-bit systems without any RAM > below 4 GB when the parameter is left at its default value. > So introduce a new default value -1 which indicates that 64-bit DMA > should

[PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-11 Thread Ard Biesheuvel
The current logic around the 'use_dac' module parameter prevents the r81969 driver from being loadable on 64-bit systems without any RAM below 4 GB when the parameter is left at its default value. So introduce a new default value -1 which indicates that 64-bit DMA should be enabled implicitly, but