Re: [PATCH] r8152: Set memory to all 0xFFs on failed reg reads

2019-08-25 Thread David Miller
From: Prashant Malani Date: Sat, 24 Aug 2019 01:36:19 -0700 > get_registers() blindly copies the memory written to by the > usb_control_msg() call even if the underlying urb failed. > > This could lead to junk register values being read by the driver, since > some indirect callers of get_registe

RE: [PATCH] r8152: Set memory to all 0xFFs on failed reg reads

2019-08-25 Thread Hayes Wang
Prashant Malani [mailto:pmal...@chromium.org] > Sent: Saturday, August 24, 2019 4:36 PM [...] > get_registers() blindly copies the memory written to by the > usb_control_msg() call even if the underlying urb failed. > > This could lead to junk register values being read by the driver, since > some

Re: [PATCH] r8152: Set memory to all 0xFFs on failed reg reads

2019-08-24 Thread David Miller
From: Prashant Malani Date: Sat, 24 Aug 2019 01:36:19 -0700 > get_registers() blindly copies the memory written to by the > usb_control_msg() call even if the underlying urb failed. > > This could lead to junk register values being read by the driver, since > some indirect callers of get_registe

[PATCH] r8152: Set memory to all 0xFFs on failed reg reads

2019-08-24 Thread Prashant Malani
get_registers() blindly copies the memory written to by the usb_control_msg() call even if the underlying urb failed. This could lead to junk register values being read by the driver, since some indirect callers of get_registers() ignore the return values. One example is: ocp_read_dword() ignore