Re: 答复: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Bjørn Mork
"Carl Yin(殷张成)" writes: > Hi Bjørn, > You can check cdc_ncm.c. > cdc ncm driver set 'rx_urb_size' on driver probe time, and the value > read from' cdc_ncm_bind_common() 's USB_CDC_GET_NTB_FORMAT '. > and also allow the userspace to modify 'rx_urb_size' by ' > /sys/class/net/w

答复: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread 殷张成
bj...@mork.no writes: > Daniele Palmas writes: > > Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH > > ha scritto: > > > >> Actually, no, this all should be done "automatically", do not change > >> the urb size on the fly. Change it at probe time based on the device > >> you are using, do not fo

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Bjørn Mork
Daniele Palmas writes: > Il giorno lun 3 ago 2020 alle ore 11:49 Greg KH > ha scritto: >> >> Where does QMI_WDA_SET_DATA_FORMAT come from? >> > > This is a request of Qualcomm proprietary protocol used, among other > things, to configure data aggregation for modems. There's an open > source users

答复: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread 殷张成
Hi Greg: I am carl, software engineer from a Chinese company ' Quectel Wireless Solutions Co., Ltd'. Chinese name is Yinzhangcheng. So English name carl.yin. My company’s products are LTE/5G modules base on QUALCOMM's chipset, like MDM9607/MDM9640/SDX24/SDX55...etc. On 20

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Bjørn Mork
Daniele Palmas writes: > Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH > ha scritto: > >> Actually, no, this all should be done "automatically", do not change the >> urb size on the fly. Change it at probe time based on the device you >> are using, do not force userspace to "know" what to do h

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Daniele Palmas
Il giorno lun 3 ago 2020 alle ore 11:49 Greg KH ha scritto: > > On Mon, Aug 03, 2020 at 10:26:18AM +0200, Daniele Palmas wrote: > > Hi Greg, > > > > Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH > > ha scritto: > > > > > > On Mon, Aug 03, 2020 at 02:51:05PM +0800, yzc...@netease.com wrote: > >

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread kernel test robot
Hi, I love your patch! Yet something to improve: [auto build test ERROR on sparc-next/master] [also build test ERROR on linus/master v5.8 next-20200731] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in h

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Greg KH
On Mon, Aug 03, 2020 at 10:26:18AM +0200, Daniele Palmas wrote: > Hi Greg, > > Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH > ha scritto: > > > > On Mon, Aug 03, 2020 at 02:51:05PM +0800, yzc...@netease.com wrote: > > > From: carl > > > > > > When QMUX enabled, the 'dl-datagram-max-size'

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Sergei Shtylyov
On 03.08.2020 9:51, yzc...@netease.com wrote: From: carl Prefrrably a full name, matching that one in the signoff tag. When QMUX enabled, the 'dl-datagram-max-size' can be 4KB/16KB/31KB depend on QUALCOMM's chipsets. No indentation here please, start at column 1 and respect th

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Daniele Palmas
Hi Greg, Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH ha scritto: > > On Mon, Aug 03, 2020 at 02:51:05PM +0800, yzc...@netease.com wrote: > > From: carl > > > > When QMUX enabled, the 'dl-datagram-max-size' can be 4KB/16KB/31KB > > depend on QUALCOMM's chipsets. > > User can set 'dl-

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Greg KH
On Mon, Aug 03, 2020 at 02:51:05PM +0800, yzc...@netease.com wrote: > From: carl > > When QMUX enabled, the 'dl-datagram-max-size' can be 4KB/16KB/31KB depend > on QUALCOMM's chipsets. > User can set 'dl-datagram-max-size' by 'QMI_WDA_SET_DATA_FORMAT'. > The usbnet's rx_urb_size must

[PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread yzc666
From: carl When QMUX enabled, the 'dl-datagram-max-size' can be 4KB/16KB/31KB depend on QUALCOMM's chipsets. User can set 'dl-datagram-max-size' by 'QMI_WDA_SET_DATA_FORMAT'. The usbnet's rx_urb_size must lager than or equal to the 'dl-datagram-max-size'. This patch allow user t