Re: [PATCH] qed: add missing header dependencies

2016-09-07 Thread David Miller
From: Baoyou Xie Date: Wed, 7 Sep 2016 19:07:00 +0800 > We get 4 warnings when building kernel with W=1: > drivers/net/ethernet/qlogic/qed/qed_selftest.c:6:5: warning: no previous > prototype for 'qed_selftest_memory' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_selftest.c:19:5:

Re: [PATCH] qed: add missing header dependencies

2016-09-07 Thread Arnd Bergmann
On Wednesday, September 7, 2016 12:31:03 PM CEST Yuval Mintz wrote: > > > While I obviously have no strong objection for including > > > qed_selftest.h from qed_selftest.c, I'm not sure I understand which C > > > standard dictates this requirement. > > > Why should a function definition [not call]

RE: [PATCH] qed: add missing header dependencies

2016-09-07 Thread Yuval Mintz
> > While I obviously have no strong objection for including > > qed_selftest.h from qed_selftest.c, I'm not sure I understand which C > > standard dictates this requirement. > > Why should a function definition [not call] be preceded by a prototype? > > - When a function is defined in one file an

Re: [PATCH] qed: add missing header dependencies

2016-09-07 Thread Arnd Bergmann
On Wednesday, September 7, 2016 11:37:07 AM CEST Yuval Mintz wrote: > > We get 4 warnings when building kernel with W=1: > > drivers/net/ethernet/qlogic/qed/qed_selftest.c:6:5: warning: no previous > > prototype for 'qed_selftest_memory' [-Wmissing-prototypes] > > drivers/net/ethernet/qlogic/qed/qe

RE: [PATCH] qed: add missing header dependencies

2016-09-07 Thread Yuval Mintz
> We get 4 warnings when building kernel with W=1: > drivers/net/ethernet/qlogic/qed/qed_selftest.c:6:5: warning: no previous > prototype for 'qed_selftest_memory' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_selftest.c:19:5: warning: no previous > prototype for 'qed_selftest_interr

[PATCH] qed: add missing header dependencies

2016-09-07 Thread Baoyou Xie
We get 4 warnings when building kernel with W=1: drivers/net/ethernet/qlogic/qed/qed_selftest.c:6:5: warning: no previous prototype for 'qed_selftest_memory' [-Wmissing-prototypes] drivers/net/ethernet/qlogic/qed/qed_selftest.c:19:5: warning: no previous prototype for 'qed_selftest_interrupt' [-W