Re: [PATCH] qed: Remove unused QED_RDMA_DEV_CAP_* symbols and dev->dev_caps

2017-12-18 Thread David Miller
From: David Miller Date: Mon, 18 Dec 2017 15:13:54 -0500 (EST) > From: Bjorn Helgaas > Date: Fri, 15 Dec 2017 17:03:01 -0600 > >> From: Bjorn Helgaas >> >> The QED_RDMA_DEV_CAP_* symbols are only used to set bits in dev->dev_caps. >> Nobody ever looks at those bits. Remove the symbols and de

Re: [PATCH] qed: Remove unused QED_RDMA_DEV_CAP_* symbols and dev->dev_caps

2017-12-18 Thread David Miller
From: Bjorn Helgaas Date: Fri, 15 Dec 2017 17:03:01 -0600 > From: Bjorn Helgaas > > The QED_RDMA_DEV_CAP_* symbols are only used to set bits in dev->dev_caps. > Nobody ever looks at those bits. Remove the symbols and dev_caps itself. > > Note that if these are ever used and added back, it loo

RE: [PATCH] qed: Remove unused QED_RDMA_DEV_CAP_* symbols and dev->dev_caps

2017-12-18 Thread Amrani, Ram
> From: Bjorn Helgaas > > The QED_RDMA_DEV_CAP_* symbols are only used to set bits in dev->dev_caps. > Nobody ever looks at those bits. Remove the symbols and dev_caps itself. > > Note that if these are ever used and added back, it looks incorrect to set > QED_RDMA_DEV_CAP_ATOMIC_OP based on PC

[PATCH] qed: Remove unused QED_RDMA_DEV_CAP_* symbols and dev->dev_caps

2017-12-15 Thread Bjorn Helgaas
From: Bjorn Helgaas The QED_RDMA_DEV_CAP_* symbols are only used to set bits in dev->dev_caps. Nobody ever looks at those bits. Remove the symbols and dev_caps itself. Note that if these are ever used and added back, it looks incorrect to set QED_RDMA_DEV_CAP_ATOMIC_OP based on PCI_EXP_DEVCTL2_