Re: [PATCH] qca8k: enable port flow control

2019-07-23 Thread xiaofeis
Hi Andrew Thanks for your comments. I have sent a new patch based on net-next tree. Thanks Xiaofeis On 2019-07-19 21:13, Andrew Lunn wrote: On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote: Set phy device advertising to enable MAC flow control. Change-Id: Ibf0f554b072fc73136ec9f7ff

Re: [PATCH] qca8k: enable port flow control

2019-07-19 Thread Andrew Lunn
> Question for DSA maintainers: shouldn't this be implemented in the > dsa_switch_ops phylink_validate callback, like it's done for other > dsa drivers? Hi Niklas qca8K is still using phylib, not phylink. So the validate callback cannot be used. Andrew

Re: [PATCH] qca8k: enable port flow control

2019-07-19 Thread Andrew Lunn
On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. > > Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae > Signed-off-by: Xiaofei Shen Hi Xiaofei What tree is this patch against? I don't think it is net-next. It actually looks t

Re: [PATCH] qca8k: enable port flow control

2019-07-19 Thread Niklas Cassel
On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. > > Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae > Signed-off-by: Xiaofei Shen > --- > drivers/net/dsa/qca8k.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >

Re: [PATCH] qca8k: enable port flow control

2019-07-18 Thread Vinod Koul
On 19-07-19, 10:53, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. How about: to Pause for enabling MAC flow control > > Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae Please remove this > Signed-off-by: Xiaofei Shen > --- > drivers/net/dsa/qca8k.c | 4 +++- >

[PATCH] qca8k: enable port flow control

2019-07-18 Thread xiaofeis
Set phy device advertising to enable MAC flow control. Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae Signed-off-by: Xiaofei Shen --- drivers/net/dsa/qca8k.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index d93be