Re: Resend: [PATCH] pktgen IPSEC 3/4: Introduce xfrm SAD only lookup

2007-07-02 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Tue, 12 Jun 2007 19:06:03 -0400 > commit 4fe3190756589ef8155eb97fe725f2564f1fc77d > Author: Jamal Hadi Salim <[EMAIL PROTECTED]> > Date: Tue Jun 12 12:35:39 2007 -0400 > > [XFRM] Introduce standalone SAD lookup > This allows other in-kernel function

Resend: [PATCH] pktgen IPSEC 3/4: Introduce xfrm SAD only lookup

2007-06-12 Thread jamal
This takes into considerations Patricks feedback. cheers, jamal commit 4fe3190756589ef8155eb97fe725f2564f1fc77d Author: Jamal Hadi Salim <[EMAIL PROTECTED]> Date: Tue Jun 12 12:35:39 2007 -0400 [XFRM] Introduce standalone SAD lookup This allows other in-kernel functions to do SAD look

Re: [PATCH] pktgen IPSEC 3/4: Introduce xfrm SAD only lookup

2007-06-12 Thread jamal
On Tue, 2007-12-06 at 15:45 +0200, Patrick McHardy wrote: > Looks good too me, just a few minor nitpicks as usual :) I like the nitpicks - they make the code better (as long as we put a time limit on them ;->) > > ^^ please delete empty line will do. > > + if (x->km.state !=

Re: [PATCH] pktgen IPSEC 3/4: Introduce xfrm SAD only lookup

2007-06-12 Thread Patrick McHardy
Looks good too me, just a few minor nitpicks as usual :) jamal wrote: > [XFRM] Introduce standalone SAD lookup > > +struct xfrm_state * > +xfrm_stateonly_find(xfrm_address_t *daddr, xfrm_address_t *saddr, > + unsigned short family, u8 mode, u8 proto, u32 reqid) > +{ > + uns

[PATCH] pktgen IPSEC 3/4: Introduce xfrm SAD only lookup

2007-06-12 Thread Robert Olsson
jamal writes: > 3 of 4 .. > [XFRM] Introduce standalone SAD lookup > This allows other in-kernel functions to do SAD lookups. > The only known user at the moment is pktgen. > > Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> xfrm is not my area. Acked-by:

[PATCH] pktgen IPSEC 3/4: Introduce xfrm SAD only lookup

2007-06-12 Thread jamal
3 of 4 .. cheers, jamal commit 677f1c1459218919f5aa2622625dc8709c2a98ce Author: Jamal Hadi Salim <[EMAIL PROTECTED]> Date: Tue Jun 12 07:28:59 2007 -0400 [XFRM] Introduce standalone SAD lookup This allows other in-kernel functions to do SAD lookups. The only known user at the momen