Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-31 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 16:48:06 -0700 > I'd like to see macros added to kernel.h for: > > pr_err > pr_notice > pr_warn > pr_alert > pr_crit > pr_emerge No objections here :) - To unsubscribe from this list: send the line "

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-31 Thread Joe Perches
On Mon, 2007-07-30 at 16:05 -0700, David Miller wrote: > I still don't know about this patch. Instead of the simple > transformation: > > - printk(foo); > + printk(KERN_INFO foo); > > we get this new macro, and the lines changes to use that macro. Actually, I agree. Many local macros c

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-30 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 16:21:00 -0700 > On Wed, 2007-07-18 at 15:49 -0700, David Miller wrote: > > From: Joe Perches <[EMAIL PROTECTED]> > > Date: Wed, 18 Jul 2007 15:14:13 -0700 > > > > > -#define VERSION "pktgen v2.68: Packet Generator for packet performan

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-18 Thread Joe Perches
On Wed, 2007-07-18 at 15:49 -0700, David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > Date: Wed, 18 Jul 2007 15:14:13 -0700 > > > -#define VERSION "pktgen v2.68: Packet Generator for packet performance > > testing.\n" > > +#define PKTGEN_NAME"pktgen" > > +#define PKTGEN_VERSION "v

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-18 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 15:14:13 -0700 > -#define VERSION "pktgen v2.68: Packet Generator for packet performance > testing.\n" > +#define PKTGEN_NAME"pktgen" > +#define PKTGEN_VERSION "v2.68" > +#define PKTGEN_DESC"Packet Generator for packet performa

[PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-18 Thread Joe Perches
Similar usage to ndev_ and dev_ printk macros Adds KERN_ indicators to all printks. Correct a spelling error Format u64 subtraction to %llu and (unsigned long long) Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/net/core/pktgen.c b/net/core/pktgen.c index b92a322..5a94cfc 100644 ---