Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-05 Thread Florian Fainelli
On 01/05/2017 01:23 AM, Zefir Kurtisi wrote: > On 01/04/2017 10:44 PM, Florian Fainelli wrote: >> On 01/04/2017 08:10 AM, Zefir Kurtisi wrote: >>> On 01/04/2017 04:30 PM, Florian Fainelli wrote: On 01/04/2017 07:27 AM, Zefir Kurtisi wrote: > On 01/04/2017 04:13 PM, Florian Fainel

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-05 Thread Zefir Kurtisi
On 01/04/2017 10:44 PM, Florian Fainelli wrote: > On 01/04/2017 08:10 AM, Zefir Kurtisi wrote: >> On 01/04/2017 04:30 PM, Florian Fainelli wrote: >>> >>> >>> On 01/04/2017 07:27 AM, Zefir Kurtisi wrote: On 01/04/2017 04:13 PM, Florian Fainelli wrote: > > > On 01/04/2017 07:04 AM, Z

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Florian Fainelli
On 01/04/2017 08:10 AM, Zefir Kurtisi wrote: > On 01/04/2017 04:30 PM, Florian Fainelli wrote: >> >> >> On 01/04/2017 07:27 AM, Zefir Kurtisi wrote: >>> On 01/04/2017 04:13 PM, Florian Fainelli wrote: On 01/04/2017 07:04 AM, Zefir Kurtisi wrote: > While in RUNNING state, phy_stat

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread kbuild test robot
Hi Zefir, [auto build test ERROR on net-next/master] [also build test ERROR on v4.10-rc2 next-20170104] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Zefir-Kurtisi/phy-state-machine-failsafe-le

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread kbuild test robot
Hi Zefir, [auto build test ERROR on net-next/master] [also build test ERROR on v4.10-rc2 next-20170104] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Zefir-Kurtisi/phy-state-machine-failsafe-le

[SIDE DISCUSSION] Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Matthias May
On 04/01/17 17:16, Andrew Lunn wrote: >> The setup is as follows: >> mv88e6321: >> * ports 0+1 connected to fibre-optics transceivers at fixed 100 Mbps >> * port 4 is CPU port >> * custom phy driver (replacement for marvell.ko) only populated with >> * .config_init to >> * set fixed speed for

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Andrew Lunn
> The setup is as follows: > mv88e6321: > * ports 0+1 connected to fibre-optics transceivers at fixed 100 Mbps > * port 4 is CPU port > * custom phy driver (replacement for marvell.ko) only populated with > * .config_init to > * set fixed speed for ports 0+1 (when in FO mode) > * run genp

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Zefir Kurtisi
On 01/04/2017 04:30 PM, Florian Fainelli wrote: > > > On 01/04/2017 07:27 AM, Zefir Kurtisi wrote: >> On 01/04/2017 04:13 PM, Florian Fainelli wrote: >>> >>> >>> On 01/04/2017 07:04 AM, Zefir Kurtisi wrote: While in RUNNING state, phy_state_machine() checks for link changes by comparing

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Zefir Kurtisi
On 01/04/2017 04:13 PM, Florian Fainelli wrote: > > > On 01/04/2017 07:04 AM, Zefir Kurtisi wrote: >> While in RUNNING state, phy_state_machine() checks for link changes by >> comparing phydev->link before and after calling phy_read_status(). >> This works as long as it is guaranteed that phydev-

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Florian Fainelli
On 01/04/2017 07:27 AM, Zefir Kurtisi wrote: > On 01/04/2017 04:13 PM, Florian Fainelli wrote: >> >> >> On 01/04/2017 07:04 AM, Zefir Kurtisi wrote: >>> While in RUNNING state, phy_state_machine() checks for link changes by >>> comparing phydev->link before and after calling phy_read_status(). >>

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Florian Fainelli
On 01/04/2017 07:04 AM, Zefir Kurtisi wrote: > While in RUNNING state, phy_state_machine() checks for link changes by > comparing phydev->link before and after calling phy_read_status(). > This works as long as it is guaranteed that phydev->link is never > changed outside the phy_state_machine().

[PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Zefir Kurtisi
While in RUNNING state, phy_state_machine() checks for link changes by comparing phydev->link before and after calling phy_read_status(). This works as long as it is guaranteed that phydev->link is never changed outside the phy_state_machine(). If in some setups this happens, it causes the state m