Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO

2016-05-16 Thread Dan Murphy
Alex On 05/16/2016 12:57 PM, Alexander Graf wrote: > Hi Dan, > > On 16.05.16 15:38, Dan Murphy wrote: >> Alexander >> >> On 05/16/2016 06:28 AM, Alexander Graf wrote: >>> The DP83867 phy driver doesn't actually work when CONFIG_OF_MDIO isn't >>> enabled. >>> It simply passes the device tree test,

Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO

2016-05-16 Thread Alexander Graf
On 16.05.16 14:44, Andrew Lunn wrote: > On Mon, May 16, 2016 at 01:28:15PM +0200, Alexander Graf wrote: >> The DP83867 phy driver doesn't actually work when CONFIG_OF_MDIO isn't >> enabled. >> It simply passes the device tree test, but leaves all internal configuration >> initialized at 0. Then

Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO

2016-05-16 Thread Alexander Graf
Hi Dan, On 16.05.16 15:38, Dan Murphy wrote: > Alexander > > On 05/16/2016 06:28 AM, Alexander Graf wrote: >> The DP83867 phy driver doesn't actually work when CONFIG_OF_MDIO isn't >> enabled. >> It simply passes the device tree test, but leaves all internal configuration >> initialized at 0. Th

Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO

2016-05-16 Thread Dan Murphy
Alexander On 05/16/2016 06:28 AM, Alexander Graf wrote: > The DP83867 phy driver doesn't actually work when CONFIG_OF_MDIO isn't > enabled. > It simply passes the device tree test, but leaves all internal configuration > initialized at 0. Then it configures the phy with those values and renders a

Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO

2016-05-16 Thread Andrew Lunn
On Mon, May 16, 2016 at 01:28:15PM +0200, Alexander Graf wrote: > The DP83867 phy driver doesn't actually work when CONFIG_OF_MDIO isn't > enabled. > It simply passes the device tree test, but leaves all internal configuration > initialized at 0. Then it configures the phy with those values and re

[PATCH] phy dp83867: depend on CONFIG_OF_MDIO

2016-05-16 Thread Alexander Graf
The DP83867 phy driver doesn't actually work when CONFIG_OF_MDIO isn't enabled. It simply passes the device tree test, but leaves all internal configuration initialized at 0. Then it configures the phy with those values and renders a previously working configuration useless. This patch makes sure