Re: [PATCH] packet: Use symmetric hash for PACKET_FANOUT_HASH.

2016-07-04 Thread Hannes Frederic Sowa
On 01.07.2016 22:08, David Miller wrote: > > People who use PACKET_FANOUT_HASH want a symmetric hash, meaning that > they want packets going in both directions on a flow to hash to the > same bucket. > > The core kernel SKB hash became non-symmetric when the ipv6 flow label > and other entities w

Re: [PATCH] packet: Use symmetric hash for PACKET_FANOUT_HASH.

2016-07-04 Thread Victor Julien
On 02-07-16 22:38, David Miller wrote: > From: Tom Herbert > Date: Fri, 1 Jul 2016 14:16:54 -0700 > >> On Fri, Jul 1, 2016 at 2:07 PM, David Miller wrote: >>> From: Tom Herbert >>> Date: Fri, 1 Jul 2016 13:52:58 -0700 >>> Why are symmetric hashes required? >>> >>> Because they want load ba

Re: [PATCH] packet: Use symmetric hash for PACKET_FANOUT_HASH.

2016-07-02 Thread David Miller
From: Tom Herbert Date: Fri, 1 Jul 2016 14:16:54 -0700 > On Fri, Jul 1, 2016 at 2:07 PM, David Miller wrote: >> From: Tom Herbert >> Date: Fri, 1 Jul 2016 13:52:58 -0700 >> >>> Why are symmetric hashes required? >> >> Because they want load balancing, such that one flow only can overrun >> one

Re: [PATCH] packet: Use symmetric hash for PACKET_FANOUT_HASH.

2016-07-01 Thread Tom Herbert
On Fri, Jul 1, 2016 at 2:07 PM, David Miller wrote: > From: Tom Herbert > Date: Fri, 1 Jul 2016 13:52:58 -0700 > >> Why are symmetric hashes required? > > Because they want load balancing, such that one flow only can overrun > one single socket not all of the ones in the fanout. > I'm still missi

Re: [PATCH] packet: Use symmetric hash for PACKET_FANOUT_HASH.

2016-07-01 Thread David Miller
From: Tom Herbert Date: Fri, 1 Jul 2016 13:52:58 -0700 > Why are symmetric hashes required? Because they want load balancing, such that one flow only can overrun one single socket not all of the ones in the fanout. Every single user of AF_PACKET fanout wants this behavior.

Re: [PATCH] packet: Use symmetric hash for PACKET_FANOUT_HASH.

2016-07-01 Thread Tom Herbert
On Fri, Jul 1, 2016 at 1:08 PM, David Miller wrote: > > People who use PACKET_FANOUT_HASH want a symmetric hash, meaning that > they want packets going in both directions on a flow to hash to the > same bucket. > > The core kernel SKB hash became non-symmetric when the ipv6 flow label > and other

[PATCH] packet: Use symmetric hash for PACKET_FANOUT_HASH.

2016-07-01 Thread David Miller
People who use PACKET_FANOUT_HASH want a symmetric hash, meaning that they want packets going in both directions on a flow to hash to the same bucket. The core kernel SKB hash became non-symmetric when the ipv6 flow label and other entities were incorporated into the standard flow hash order to i