Re: [PATCH] packet: Do not leak dev refcounts on error exit

2019-01-08 Thread David Miller
From: Jason Gunthorpe Date: Tue, 8 Jan 2019 23:27:06 + > 'dev' is non NULL when the addr_len check triggers so it must goto a label > that does the dev_put otherwise dev will have a leaked refcount. > > This bug causes the ib_ipoib module to become unloadable when using > systemd-network as

Re: [PATCH] packet: Do not leak dev refcounts on error exit

2019-01-08 Thread Willem de Bruijn
On Tue, Jan 8, 2019 at 6:41 PM Jason Gunthorpe wrote: > > 'dev' is non NULL when the addr_len check triggers so it must goto a label > that does the dev_put otherwise dev will have a leaked refcount. > > This bug causes the ib_ipoib module to become unloadable when using > systemd-network as it tr

[PATCH] packet: Do not leak dev refcounts on error exit

2019-01-08 Thread Jason Gunthorpe
'dev' is non NULL when the addr_len check triggers so it must goto a label that does the dev_put otherwise dev will have a leaked refcount. This bug causes the ib_ipoib module to become unloadable when using systemd-network as it triggers this check on InfiniBand links. Fixes: 99137b7888f4 ("pack