Re: [PATCH] p54: add null pointer check before releasing socket buffer

2017-04-10 Thread Eric Dumazet
On Mon, Apr 10, 2017 at 2:22 PM, Christian Lamparter wrote: > Well, the patch could be as simple as this: > --- > diff --git a/net/core/dev.c b/net/core/dev.c > index 7869ae3837ca..44f7d5a1c67c 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -2450,6 +2450,9 @@ void __dev_kfree_skb_irq(s

Re: [PATCH] p54: add null pointer check before releasing socket buffer

2017-04-10 Thread Christian Lamparter
On Monday, April 10, 2017 1:54:14 PM CEST Myungho Jung wrote: > On Mon, Apr 10, 2017 at 02:12:54PM +0200, Christian Lamparter wrote: > > On Sunday, April 9, 2017 10:23:20 PM CEST Myungho Jung wrote: > > > Kernel panic is caused by trying to dereference null pointer. Check if > > > the pointer is nu

Re: [PATCH] p54: add null pointer check before releasing socket buffer

2017-04-10 Thread Myungho Jung
On Mon, Apr 10, 2017 at 02:12:54PM +0200, Christian Lamparter wrote: > (Added linux-wireless, since this is a wireless driver) > > On Sunday, April 9, 2017 10:23:20 PM CEST Myungho Jung wrote: > > Kernel panic is caused by trying to dereference null pointer. Check if > > the pointer is null before

Re: [PATCH] p54: add null pointer check before releasing socket buffer

2017-04-10 Thread David Miller
From: Myungho Jung Date: Sun, 9 Apr 2017 22:23:20 -0700 > Kernel panic is caused by trying to dereference null pointer. Check if > the pointer is null before freeing space. > > Signed-off-by: Myungho Jung Your tests are backwards, you therefore did not test your change. In fact, your change i

Re: [PATCH] p54: add null pointer check before releasing socket buffer

2017-04-10 Thread Christian Lamparter
(Added linux-wireless, since this is a wireless driver) On Sunday, April 9, 2017 10:23:20 PM CEST Myungho Jung wrote: > Kernel panic is caused by trying to dereference null pointer. Check if > the pointer is null before freeing space. Do you have the kernel panic somewhere? I think you have an eve

[PATCH] p54: add null pointer check before releasing socket buffer

2017-04-09 Thread Myungho Jung
Kernel panic is caused by trying to dereference null pointer. Check if the pointer is null before freeing space. Signed-off-by: Myungho Jung --- drivers/net/wireless/intersil/p54/txrx.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intersil/p54/