Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-29 Thread Frank Rowand
On 4/29/19 5:48 PM, Rob Herring wrote: > On Tue, Apr 16, 2019 at 08:01:56PM -0700, Frank Rowand wrote: >> Hi Rob, >> >> On 4/16/19 5:29 PM, Florian Fainelli wrote: >>> >>> >>> On 16/04/2019 13:05, Petr Štetiar wrote: From: John Crispin Many embedded devices have information such as

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-29 Thread Rob Herring
On Tue, Apr 16, 2019 at 08:01:56PM -0700, Frank Rowand wrote: > Hi Rob, > > On 4/16/19 5:29 PM, Florian Fainelli wrote: > > > > > > On 16/04/2019 13:05, Petr Štetiar wrote: > >> From: John Crispin > >> > >> Many embedded devices have information such as MAC addresses stored > >> inside MTD devi

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-17 Thread Maxime Ripard
On Wed, Apr 17, 2019 at 06:06:00PM +0200, Petr Štetiar wrote: > Maxime Ripard [2019-04-17 10:06:14]: > > > NVMEM is supported by of_net already > > Well, not anymore: > > commit afa64a72b862a7a9d04f8d07fba632eaf06b23f8 > Author: Bartosz Golaszewski > Date: Fri Nov 30 09:20:59 2018 +0100 > >

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-17 Thread Petr Štetiar
Maxime Ripard [2019-04-17 10:06:14]: > NVMEM is supported by of_net already Well, not anymore: commit afa64a72b862a7a9d04f8d07fba632eaf06b23f8 Author: Bartosz Golaszewski Date: Fri Nov 30 09:20:59 2018 +0100 of: net: kill of_get_nvmem_mac_address() Now, I'm really confused. Documen

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-17 Thread Petr Štetiar
Maxime Ripard [2019-04-17 12:15:57]: > https://elixir.bootlin.com/linux/latest/source/net/ethernet/eth.c#L564 Thanks, so if I parse those 2 use cases of nvmem_get_mac_address correctly: drivers/net/ethernet/cadence/macb_main.c: err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr); dri

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-17 Thread Maxime Ripard
On Wed, Apr 17, 2019 at 11:49:21AM +0200, Petr Štetiar wrote: > Maxime Ripard [2019-04-17 10:06:14]: > > Hi Maxime, > > > On Tue, Apr 16, 2019 at 10:05:00PM +0200, Petr Štetiar wrote: > > > From: John Crispin > > > > > > Many embedded devices have information such as MAC addresses stored > > > in

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-17 Thread Petr Štetiar
Maxime Ripard [2019-04-17 10:06:14]: Hi Maxime, > On Tue, Apr 16, 2019 at 10:05:00PM +0200, Petr Štetiar wrote: > > From: John Crispin > > > > Many embedded devices have information such as MAC addresses stored > > inside MTD devices. This patch allows us to add a property inside a node > > des

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-17 Thread Maxime Ripard
On Tue, Apr 16, 2019 at 10:05:00PM +0200, Petr Štetiar wrote: > From: John Crispin > > Many embedded devices have information such as MAC addresses stored > inside MTD devices. This patch allows us to add a property inside a node > describing a network interface. The new property points at a MTD >

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-16 Thread Heiner Kallweit
On 16.04.2019 22:05, Petr Štetiar wrote: > From: John Crispin > > Many embedded devices have information such as MAC addresses stored > inside MTD devices. This patch allows us to add a property inside a node > describing a network interface. The new property points at a MTD > partition with an o

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-16 Thread Frank Rowand
Hi Rob, On 4/16/19 5:29 PM, Florian Fainelli wrote: > > > On 16/04/2019 13:05, Petr Štetiar wrote: >> From: John Crispin >> >> Many embedded devices have information such as MAC addresses stored >> inside MTD devices. This patch allows us to add a property inside a node >> describing a network

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-16 Thread Florian Fainelli
On 16/04/2019 13:05, Petr Štetiar wrote: From: John Crispin Many embedded devices have information such as MAC addresses stored inside MTD devices. This patch allows us to add a property inside a node describing a network interface. The new property points at a MTD partition with an offset w

[PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-16 Thread Petr Štetiar
From: John Crispin Many embedded devices have information such as MAC addresses stored inside MTD devices. This patch allows us to add a property inside a node describing a network interface. The new property points at a MTD partition with an offset where the MAC address can be found. This patch