Re: [PATCH] of_mdio: use of_property_read_u32_array()

2017-08-07 Thread David Miller
From: Sergei Shtylyov Date: Sat, 05 Aug 2017 00:43:43 +0300 > The "fixed-link" prop support predated of_property_read_u32_array(), so > basically had to open-code it. Using the modern API saves 24 bytes of the > object code (ARM gcc 4.8.5); the only behavior change would be that the > prop length

Re: [PATCH] of_mdio: use of_property_read_u32_array()

2017-08-07 Thread Rob Herring
On Mon, Aug 7, 2017 at 1:01 PM, Florian Fainelli wrote: > On 08/07/2017 09:18 AM, Sergei Shtylyov wrote: >> Hello! >> >> On 08/07/2017 05:18 PM, Rob Herring wrote: >> The "fixed-link" prop support predated of_property_read_u32_array(), so basically had to open-code it. Using the modern A

Re: [PATCH] of_mdio: use of_property_read_u32_array()

2017-08-07 Thread Florian Fainelli
On 08/07/2017 09:18 AM, Sergei Shtylyov wrote: > Hello! > > On 08/07/2017 05:18 PM, Rob Herring wrote: > >>> The "fixed-link" prop support predated of_property_read_u32_array(), so >>> basically had to open-code it. Using the modern API saves 24 bytes of >>> the >>> object code (ARM gcc 4.8.5); t

Re: [PATCH] of_mdio: use of_property_read_u32_array()

2017-08-07 Thread Sergei Shtylyov
Hello! On 08/07/2017 05:18 PM, Rob Herring wrote: The "fixed-link" prop support predated of_property_read_u32_array(), so basically had to open-code it. Using the modern API saves 24 bytes of the object code (ARM gcc 4.8.5); the only behavior change would be that the prop length check is now le

Re: [PATCH] of_mdio: use of_property_read_u32_array()

2017-08-07 Thread Rob Herring
On Fri, Aug 4, 2017 at 4:43 PM, Sergei Shtylyov wrote: > The "fixed-link" prop support predated of_property_read_u32_array(), so > basically had to open-code it. Using the modern API saves 24 bytes of the > object code (ARM gcc 4.8.5); the only behavior change would be that the > prop length check

Re: [PATCH] of_mdio: use of_property_read_u32_array()

2017-08-04 Thread Andrew Lunn
On Sat, Aug 05, 2017 at 12:43:43AM +0300, Sergei Shtylyov wrote: > The "fixed-link" prop support predated of_property_read_u32_array(), so > basically had to open-code it. Using the modern API saves 24 bytes of the > object code (ARM gcc 4.8.5); the only behavior change would be that the > prop len

[PATCH] of_mdio: use of_property_read_u32_array()

2017-08-04 Thread Sergei Shtylyov
The "fixed-link" prop support predated of_property_read_u32_array(), so basically had to open-code it. Using the modern API saves 24 bytes of the object code (ARM gcc 4.8.5); the only behavior change would be that the prop length check is now less strict (however the strict pre-check done in of_phy