Re: [PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-08 Thread Yunsheng Lin
On 2020/5/8 21:01, Andrew Lunn wrote: > On Fri, May 08, 2020 at 01:08:13PM +0530, Sunil Kovvuri wrote: >> On Fri, May 8, 2020 at 11:00 AM Kevin Hao wrote: >>> >>> On Fri, May 08, 2020 at 10:18:27AM +0530, Sunil Kovvuri wrote: On Fri, May 8, 2020 at 9:43 AM Kevin Hao wrote: > > In the

Re: [PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-08 Thread Andrew Lunn
On Fri, May 08, 2020 at 01:08:13PM +0530, Sunil Kovvuri wrote: > On Fri, May 8, 2020 at 11:00 AM Kevin Hao wrote: > > > > On Fri, May 08, 2020 at 10:18:27AM +0530, Sunil Kovvuri wrote: > > > On Fri, May 8, 2020 at 9:43 AM Kevin Hao wrote: > > > > > > > > In the current codes, the octeontx2 uses i

Re: [PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-08 Thread Kevin Hao
On Fri, May 08, 2020 at 01:10:00PM +0530, Sunil Kovvuri wrote: > On Fri, May 8, 2020 at 9:43 AM Kevin Hao wrote: > > > > In the current codes, the octeontx2 uses its own method to allocate > > the pool buffers, but there are some issues in this implementation. > > 1. We have to run the otx2_get_pa

Re: [PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-08 Thread Sunil Kovvuri
On Fri, May 8, 2020 at 9:43 AM Kevin Hao wrote: > > In the current codes, the octeontx2 uses its own method to allocate > the pool buffers, but there are some issues in this implementation. > 1. We have to run the otx2_get_page() for each allocation cycle and >this is pretty error prone. As I

Re: [PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-08 Thread Sunil Kovvuri
On Fri, May 8, 2020 at 11:00 AM Kevin Hao wrote: > > On Fri, May 08, 2020 at 10:18:27AM +0530, Sunil Kovvuri wrote: > > On Fri, May 8, 2020 at 9:43 AM Kevin Hao wrote: > > > > > > In the current codes, the octeontx2 uses its own method to allocate > > > the pool buffers, but there are some issues

Re: [PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-07 Thread Kevin Hao
On Fri, May 08, 2020 at 10:18:27AM +0530, Sunil Kovvuri wrote: > On Fri, May 8, 2020 at 9:43 AM Kevin Hao wrote: > > > > In the current codes, the octeontx2 uses its own method to allocate > > the pool buffers, but there are some issues in this implementation. > > 1. We have to run the otx2_get_pa

Re: [PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-07 Thread Sunil Kovvuri
On Fri, May 8, 2020 at 9:43 AM Kevin Hao wrote: > > In the current codes, the octeontx2 uses its own method to allocate > the pool buffers, but there are some issues in this implementation. > 1. We have to run the otx2_get_page() for each allocation cycle and >this is pretty error prone. As I

[PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-07 Thread Kevin Hao
In the current codes, the octeontx2 uses its own method to allocate the pool buffers, but there are some issues in this implementation. 1. We have to run the otx2_get_page() for each allocation cycle and this is pretty error prone. As I can see there is no invocation of the otx2_get_page() in