Re: [netfilter-core] [PATCH] netfilter: nfnetlink_queue: Unregister pernet subsys in case of init failure

2015-12-09 Thread Pablo Neira Ayuso
On Mon, Dec 07, 2015 at 02:17:46PM +0100, Pablo Neira Ayuso wrote: > On Mon, Dec 07, 2015 at 02:58:44PM +0200, Nikolay Borisov wrote: > > > > > > On 12/07/2015 02:29 PM, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 12/07/2015 01:13 PM, Nikolay Borisov wrote: > > > > > >> Commit 3bfe049807

Re: [PATCH] netfilter: nfnetlink_queue: Unregister pernet subsys in case of init failure

2015-12-07 Thread Pablo Neira Ayuso
On Mon, Dec 07, 2015 at 02:58:44PM +0200, Nikolay Borisov wrote: > > > On 12/07/2015 02:29 PM, Sergei Shtylyov wrote: > > Hello. > > > > On 12/07/2015 01:13 PM, Nikolay Borisov wrote: > > > >> Commit 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}: > > > >Double quotes please, that's wh

Re: [PATCH] netfilter: nfnetlink_queue: Unregister pernet subsys in case of init failure

2015-12-07 Thread Nikolay Borisov
On 12/07/2015 02:29 PM, Sergei Shtylyov wrote: > Hello. > > On 12/07/2015 01:13 PM, Nikolay Borisov wrote: > >> Commit 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}: > >Double quotes please, that's what scripts/checkpatch.pl enforces now. > >> Register pernet in first place') reorgan

Re: [PATCH] netfilter: nfnetlink_queue: Unregister pernet subsys in case of init failure

2015-12-07 Thread Sergei Shtylyov
Hello. On 12/07/2015 01:13 PM, Nikolay Borisov wrote: Commit 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}: Double quotes please, that's what scripts/checkpatch.pl enforces now. Register pernet in first place') reorganised the initialisation order of the pernet_subsys to avoid "use-

[PATCH] netfilter: nfnetlink_queue: Unregister pernet subsys in case of init failure

2015-12-07 Thread Nikolay Borisov
Commit 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}: Register pernet in first place') reorganised the initialisation order of the pernet_subsys to avoid "use-before-initialised" condition. However, in doing so the cleanup logic in nfnetlink_queue got botched in that the pernet_subsys wasn't c