Re: [PATCH] netfilter: mark expected switch fall-throughs

2017-11-07 Thread Gustavo A. R. Silva
Hello Pablo, Quoting Pablo Neira Ayuso : Hi Gustavo, On Thu, Oct 19, 2017 at 09:06:16AM -0500, Gustavo A. R. Silva wrote: diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index cf84f7b..72f654a 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfil

Re: [PATCH] netfilter: mark expected switch fall-throughs

2017-11-06 Thread Pablo Neira Ayuso
Hi Gustavo, On Thu, Oct 19, 2017 at 09:06:16AM -0500, Gustavo A. R. Silva wrote: > diff --git a/net/netfilter/ipset/ip_set_core.c > b/net/netfilter/ipset/ip_set_core.c > index cf84f7b..72f654a 100644 > --- a/net/netfilter/ipset/ip_set_core.c > +++ b/net/netfilter/ipset/ip_set_core.c > @@ -1386,7

[PATCH] netfilter: mark expected switch fall-throughs

2017-10-19 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in some cases I placed the "fall through" comment on its own line, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compi