Re: [PATCH] netfilter: ctnetlink: Make some parameters integer to avoid enum mismatch

2017-05-02 Thread Pablo Neira Ayuso
On Mon, May 01, 2017 at 11:07:30AM -0700, Matthias Kaehlcke wrote: > El Wed, Apr 19, 2017 at 11:39:20AM -0700 Matthias Kaehlcke ha dit: > > > Not all parameters passed to ctnetlink_parse_tuple() and > > ctnetlink_exp_dump_tuple() match the enum type in the signatures of these > > functions. Since

Re: [PATCH] netfilter: ctnetlink: Make some parameters integer to avoid enum mismatch

2017-05-01 Thread Matthias Kaehlcke
El Wed, Apr 19, 2017 at 11:39:20AM -0700 Matthias Kaehlcke ha dit: > Not all parameters passed to ctnetlink_parse_tuple() and > ctnetlink_exp_dump_tuple() match the enum type in the signatures of these > functions. Since this is intended change the argument type of to be an int > value. > > Signe

Re: [PATCH] netfilter: ctnetlink: Make some parameters integer to avoid enum mismatch

2017-04-19 Thread Matthias Kaehlcke
El Wed, Apr 19, 2017 at 12:41:10PM -0700 Joe Perches ha dit: > On Wed, 2017-04-19 at 11:39 -0700, Matthias Kaehlcke wrote: > > Not all parameters passed to ctnetlink_parse_tuple() and > > ctnetlink_exp_dump_tuple() match the enum type in the signatures of these > > functions. > > Maybe that shoul

Re: [PATCH] netfilter: ctnetlink: Make some parameters integer to avoid enum mismatch

2017-04-19 Thread Joe Perches
On Wed, 2017-04-19 at 11:39 -0700, Matthias Kaehlcke wrote: > Not all parameters passed to ctnetlink_parse_tuple() and > ctnetlink_exp_dump_tuple() match the enum type in the signatures of these > functions. Maybe that should be changed/fixed. > Since this is intended change the argument type of

[PATCH] netfilter: ctnetlink: Make some parameters integer to avoid enum mismatch

2017-04-19 Thread Matthias Kaehlcke
Not all parameters passed to ctnetlink_parse_tuple() and ctnetlink_exp_dump_tuple() match the enum type in the signatures of these functions. Since this is intended change the argument type of to be an int value. Signed-off-by: Matthias Kaehlcke --- net/netfilter/nf_conntrack_netlink.c | 7 +++--