Re: [PATCH] netfiler: ipset: fix unaligned atomic access

2020-06-22 Thread Russell King - ARM Linux admin
On Mon, Jun 22, 2020 at 10:26:33AM +0200, Pablo Neira Ayuso wrote: > On Wed, Jun 10, 2020 at 09:51:11PM +0100, Russell King wrote: > > When using ip_set with counters and comment, traffic causes the kernel > > to panic on 32-bit ARM: > > > > Alignment trap: not handling instruction e1b82f9f at []

Re: [PATCH] netfiler: ipset: fix unaligned atomic access

2020-06-22 Thread Pablo Neira Ayuso
On Wed, Jun 10, 2020 at 09:51:11PM +0100, Russell King wrote: > When using ip_set with counters and comment, traffic causes the kernel > to panic on 32-bit ARM: > > Alignment trap: not handling instruction e1b82f9f at [] > Unhandled fault: alignment exception (0x221) at 0xea08133c > PC is at ip_se

Re: [PATCH] netfiler: ipset: fix unaligned atomic access

2020-06-21 Thread Jozsef Kadlecsik
Hi, On Sun, 21 Jun 2020, Pablo Neira Ayuso wrote: > I'll place in this in nf.git unless you have any objection. No objection at all and thanks! Acked-by: Jozsef Kadlecsik Best regards, Jozsef > On Sun, Jun 21, 2020 at 08:45:14PM +0100, Russell King - ARM Linux admin > wrote: > > Gentle ping

Re: [PATCH] netfiler: ipset: fix unaligned atomic access

2020-06-21 Thread Pablo Neira Ayuso
Hi Jozsef, I'll place in this in nf.git unless you have any objection. Thanks. On Sun, Jun 21, 2020 at 08:45:14PM +0100, Russell King - ARM Linux admin wrote: > Gentle ping... > > This patch fixes a remotely triggerable kernel oops, and as such can > be viewed as a remote denial of service atta

Re: [PATCH] netfiler: ipset: fix unaligned atomic access

2020-06-21 Thread Russell King - ARM Linux admin
Gentle ping... This patch fixes a remotely triggerable kernel oops, and as such can be viewed as a remote denial of service attack depending on the netfilter rule setup. On Wed, Jun 10, 2020 at 09:51:11PM +0100, Russell King wrote: > When using ip_set with counters and comment, traffic causes the

[PATCH] netfiler: ipset: fix unaligned atomic access

2020-06-10 Thread Russell King
When using ip_set with counters and comment, traffic causes the kernel to panic on 32-bit ARM: Alignment trap: not handling instruction e1b82f9f at [] Unhandled fault: alignment exception (0x221) at 0xea08133c PC is at ip_set_match_extensions+0xe0/0x224 [ip_set] The problem occurs when we try to