Re: [PATCH] net_sched: reset pointers to tcf blocks in classful qdiscs' destructors

2017-08-15 Thread David Miller
From: Konstantin Khlebnikov Date: Tue, 15 Aug 2017 16:35:21 +0300 > Traffic filters could keep direct pointers to classes in classful qdisc, > thus qdisc destruction first removes all filters before freeing classes. > Class destruction methods also tries to free attached filters but now > this is

Re: [PATCH] net_sched: reset pointers to tcf blocks in classful qdiscs' destructors

2017-08-15 Thread Jiri Pirko
Tue, Aug 15, 2017 at 03:35:21PM CEST, khlebni...@yandex-team.ru wrote: >Traffic filters could keep direct pointers to classes in classful qdisc, >thus qdisc destruction first removes all filters before freeing classes. >Class destruction methods also tries to free attached filters but now >this isn

[PATCH] net_sched: reset pointers to tcf blocks in classful qdiscs' destructors

2017-08-15 Thread Konstantin Khlebnikov
Traffic filters could keep direct pointers to classes in classful qdisc, thus qdisc destruction first removes all filters before freeing classes. Class destruction methods also tries to free attached filters but now this isn't safe because tcf_block_put() unlike to tcf_destroy_chain() cannot be cal