Re: [PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

2016-01-29 Thread David Miller
From: Bernie Harris Date: Thu, 28 Jan 2016 16:30:51 +1300 > There are cases where qdisc_dequeue_peeked can return NULL, and the result > is dereferenced later on in the function. > > Similarly to the other qdisc dequeue functions, check whether the skb > pointer is NULL and if it is, goto out. >

Re: [PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

2016-01-29 Thread Cong Wang
On Wed, Jan 27, 2016 at 7:30 PM, Bernie Harris wrote: > There are cases where qdisc_dequeue_peeked can return NULL, and the result > is dereferenced later on in the function. > > Similarly to the other qdisc dequeue functions, check whether the skb > pointer is NULL and if it is, goto out. > > Sig

Re: [PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

2016-01-28 Thread Sergei Shtylyov
Hello. On 1/28/2016 6:30 AM, Bernie Harris wrote: There are cases where qdisc_dequeue_peeked can return NULL, and the result is dereferenced later on in the function. Similarly to the other qdisc dequeue functions, check whether the skb pointer is NULL and if it is, goto out. Signed-off-by: B

[PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

2016-01-27 Thread Bernie Harris
There are cases where qdisc_dequeue_peeked can return NULL, and the result is dereferenced later on in the function. Similarly to the other qdisc dequeue functions, check whether the skb pointer is NULL and if it is, goto out. Signed-off-by: Bernie Harris --- net/sched/sch_drr.c | 2 ++ 1 file

Re: [PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

2016-01-27 Thread Bernie Harris
for NULL pointer in drr_dequeue On Mon, Jan 25, 2016 at 7:51 PM, Bernie Harris wrote: > There are cases where qdisc_dequeue_peeked can return NULL, and the result > is dereferenced later on in the function. > > Similarly to the other qdisc dequeue functions, check whether the skb

Re: [PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

2016-01-26 Thread Cong Wang
On Mon, Jan 25, 2016 at 7:51 PM, Bernie Harris wrote: > There are cases where qdisc_dequeue_peeked can return NULL, and the result > is dereferenced later on in the function. > > Similarly to the other qdisc dequeue functions, check whether the skb > pointer is NULL and if it is, goto out. > > Sig

[PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

2016-01-25 Thread Bernie Harris
There are cases where qdisc_dequeue_peeked can return NULL, and the result is dereferenced later on in the function. Similarly to the other qdisc dequeue functions, check whether the skb pointer is NULL and if it is, goto out. Signed-off-by: Bernie Harris --- net/sched/sch_drr.c | 2 ++ 1 file