Re: [PATCH] net_sched/sfq: update hierarchical backlog when drop packet

2017-08-15 Thread David Miller
From: Konstantin Khlebnikov Date: Tue, 15 Aug 2017 16:37:04 +0300 > When sfq_enqueue() drops head packet or packet from another queue it > have to update backlog at upper qdiscs too. > > Signed-off-by: Konstantin Khlebnikov > Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") A

Re: [PATCH] net_sched/sfq: update hierarchical backlog when drop packet

2017-08-15 Thread Eric Dumazet
On Tue, 2017-08-15 at 17:33 +0300, Konstantin Khlebnikov wrote: > Nope. I'm not sure. But we have something similar in our 4.4 kernel > for a while. > > Also fq_codel and pfifo_head_drop do something similar tho this. > > Probably this might crash without "[PATCH 1/2] net_sched: call > qlen_noti

Re: [PATCH] net_sched/sfq: update hierarchical backlog when drop packet

2017-08-15 Thread Konstantin Khlebnikov
On 15.08.2017 17:09, Eric Dumazet wrote: On Tue, 2017-08-15 at 16:37 +0300, Konstantin Khlebnikov wrote: When sfq_enqueue() drops head packet or packet from another queue it have to update backlog at upper qdiscs too. Signed-off-by: Konstantin Khlebnikov Fixes: 2f5fb43f ("net_sched: update

Re: [PATCH] net_sched/sfq: update hierarchical backlog when drop packet

2017-08-15 Thread Eric Dumazet
On Tue, 2017-08-15 at 16:37 +0300, Konstantin Khlebnikov wrote: > When sfq_enqueue() drops head packet or packet from another queue it > have to update backlog at upper qdiscs too. > > Signed-off-by: Konstantin Khlebnikov > Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") > ---

[PATCH] net_sched/sfq: update hierarchical backlog when drop packet

2017-08-15 Thread Konstantin Khlebnikov
When sfq_enqueue() drops head packet or packet from another queue it have to update backlog at upper qdiscs too. Signed-off-by: Konstantin Khlebnikov Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") --- net/sched/sch_sfq.c |5 - 1 file changed, 4 insertions(+), 1 deleti