Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-04 Thread Joe Perches
On Tue, 2015-08-04 at 17:07 +0200, Jason A. Donenfeld wrote: > The pr_debug family of functions turns into a no-op when -DDEBUG is not > specified, opting instead to call "no_printk", which gets compiled to a > no-op (but retains gcc's nice warnings about printf-style arguments). [] > diff --git a/

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-04 Thread Jason A. Donenfeld
Sorry, I forgot to 'v2' the subject, but here's the respin suggested by Joe and asked for by David. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-04 Thread Jason A. Donenfeld
The pr_debug family of functions turns into a no-op when -DDEBUG is not specified, opting instead to call "no_printk", which gets compiled to a no-op (but retains gcc's nice warnings about printf-style arguments). The problem with net_dbg_ratelimited is that it is defined to be a variant of net_ra

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread David Miller
From: Joe Perches Date: Mon, 03 Aug 2015 21:02:21 -0700 > On Mon, 2015-08-03 at 20:57 -0700, Joe Perches wrote: >> On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote: >> > This patch replaces calls to net_dbg_ratelimited when !DEBUG with >> > no_printk, keeping with the idiom of all the

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread Joe Perches
On Mon, 2015-08-03 at 20:57 -0700, Joe Perches wrote: > On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote: > > This patch replaces calls to net_dbg_ratelimited when !DEBUG with > > no_printk, keeping with the idiom of all the other debug print helpers. > > Makes sense, thanks Jason. Per

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread Joe Perches
On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote: > The pr_debug family of functions turns into a no-op when -DDEBUG is not > specified, opting instead to call "no_printk", which gets compiled to a > no-op (but retains gcc's nice warnings about printf-style arguments). > > The problem w

[PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread Jason A. Donenfeld
The pr_debug family of functions turns into a no-op when -DDEBUG is not specified, opting instead to call "no_printk", which gets compiled to a no-op (but retains gcc's nice warnings about printf-style arguments). The problem with net_dbg_ratelimited is that it is defined to be a variant of net_ra