Re: [PATCH] net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int

2018-09-26 Thread David Miller
From: "Maciej Żenczykowski" Date: Tue, 25 Sep 2018 21:59:28 -0700 > From: Maciej Żenczykowski > > (fix documentation and sysctl access to treat it as such) > > Tested: > # zcat /proc/config.gz | egrep ^CONFIG_HZ > CONFIG_HZ_1000=y > CONFIG_HZ=1000 > # echo $[(1<<32)/1000 + 1] | tee /pr

[PATCH] net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int

2018-09-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski (fix documentation and sysctl access to treat it as such) Tested: # zcat /proc/config.gz | egrep ^CONFIG_HZ CONFIG_HZ_1000=y CONFIG_HZ=1000 # echo $[(1<<32)/1000 + 1] | tee /proc/sys/net/ipv4/tcp_probe_interval 4294968 tee: /proc/sys/net/ipv4/tcp_probe_inter

Re: [PATCH] net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int

2018-09-25 Thread Eric Dumazet
On 09/25/2018 05:41 PM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > (fix documentation and sysctl access to treat it as such) > > Signed-off-by: Maciej Żenczykowski > --- While we are at it, we probably should add sane limits, given tcp_mtu_check_reprobe() does : u32 interva

[PATCH] net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int

2018-09-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski (fix documentation and sysctl access to treat it as such) Signed-off-by: Maciej Żenczykowski --- Documentation/networking/ip-sysctl.txt | 2 +- net/ipv4/sysctl_net_ipv4.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentatio