Re: [PATCH] net: use unlikely for dql_avail case

2019-09-26 Thread Eric Dumazet
On 9/25/19 5:25 AM, Daniel Borkmann wrote: > On Wed, Sep 25, 2019 at 10:40:43AM +0800, xiaolinkui wrote: >> This is an unlikely case, use unlikely() on it seems logical. >> >> Signed-off-by: xiaolinkui > > It's already here [0], but should probably rather get reverted instead > due to lack of

Re: [PATCH] net: use unlikely for dql_avail case

2019-09-25 Thread Daniel Borkmann
On Wed, Sep 25, 2019 at 10:40:43AM +0800, xiaolinkui wrote: > This is an unlikely case, use unlikely() on it seems logical. > > Signed-off-by: xiaolinkui It's already here [0], but should probably rather get reverted instead due to lack of a more elaborate reasoning on why it needs to be done th

[PATCH] net: use unlikely for dql_avail case

2019-09-24 Thread xiaolinkui
This is an unlikely case, use unlikely() on it seems logical. Signed-off-by: xiaolinkui --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 88292953aa6f..005f3da1b13d 100644 --- a/include/li

Re: [PATCH] net: use unlikely for dql_avail case

2019-08-24 Thread David Miller
From: xiaolinkui Date: Thu, 22 Aug 2019 14:58:16 +0800 > This is an unlikely case, use unlikely() on it seems logical. > > Signed-off-by: xiaolinkui Applied to net-next.

[PATCH] net: use unlikely for dql_avail case

2019-08-21 Thread xiaolinkui
This is an unlikely case, use unlikely() on it seems logical. Signed-off-by: xiaolinkui --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 88292953aa6f..005f3da1b13d 100644 --- a/include/li