Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Oliver Neukum
Am Montag, den 06.11.2017, 17:05 +0100 schrieb Andrey Konovalov: > On Mon, Nov 6, 2017 at 4:20 PM, Oliver Neukum wrote: > > > I do have a way to reproduce this. > > As far as I understand, for this particular device ax88172_bind() is > called, which doesn't assign anything to dev->driver_priv,

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Andrey Konovalov
On Mon, Nov 6, 2017 at 4:20 PM, Oliver Neukum wrote: > Am Montag, den 06.11.2017, 13:30 +0100 schrieb Andrey Konovalov: >> On Mon, Nov 6, 2017 at 10:49 AM, Oliver Neukum wrote: >> > >> > >> > 2. Will a device work after that? The appropriate fix may be to wait >> > until the device is properly in

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Oliver Neukum
Am Montag, den 06.11.2017, 13:30 +0100 schrieb Andrey Konovalov: > On Mon, Nov 6, 2017 at 10:49 AM, Oliver Neukum wrote: > > > > > > 2. Will a device work after that? The appropriate fix may be to wait > > until the device is properly initialized. > > This shouldn't affect real devices as far a

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Andrey Konovalov
On Mon, Nov 6, 2017 at 10:49 AM, Oliver Neukum wrote: > Am Donnerstag, den 02.11.2017, 21:26 +0100 schrieb Andrey Konovalov: >> When asix_suspend() is called dev->driver_priv might not have been >> assigned a value, so we need to check that it's not NULL. >> >> Found by syzkaller. > > Hi, Hi Oliv

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-06 Thread Oliver Neukum
Am Donnerstag, den 02.11.2017, 21:26 +0100 schrieb Andrey Konovalov: > When asix_suspend() is called dev->driver_priv might not have been > assigned a value, so we need to check that it's not NULL. > > Found by syzkaller. Hi, 1. if that happens on suspend, it will also happen on resume 2. Will a

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-04 Thread David Miller
From: Andrey Konovalov Date: Thu, 2 Nov 2017 21:26:59 +0100 > When asix_suspend() is called dev->driver_priv might not have been > assigned a value, so we need to check that it's not NULL. > > Found by syzkaller. ... > Signed-off-by: Andrey Konovalov Applied, thank you.

[PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-02 Thread Andrey Konovalov
When asix_suspend() is called dev->driver_priv might not have been assigned a value, so we need to check that it's not NULL. Found by syzkaller. kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] PREEMPT SMP KA