Re: [PATCH] net: tipc: fix general protection fault in tipc_conn_delete_sub

2020-07-28 Thread Ying Xue
On 7/27/20 10:24 PM, Greg KH wrote: diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c index 1489cfb941d8..6c8d0c6bb112 100644 --- a/net/tipc/topsrv.c +++ b/net/tipc/topsrv.c @@ -255,6 +255,9 @@ static void tipc_conn_send_to_sock(struct tipc_conn *con) int

Re: [PATCH] net: tipc: fix general protection fault in tipc_conn_delete_sub

2020-07-27 Thread David Miller
From: kernel test robot Date: Mon, 27 Jul 2020 23:52:50 +0800 > All warnings (new ones prefixed by >>): > >net/tipc/topsrv.c: In function 'tipc_conn_send_to_sock': >>> net/tipc/topsrv.c:259:10: warning: 'return' with a value, in function >>> returning void [-Wreturn-type] > 259 | ret

Re: [PATCH] net: tipc: fix general protection fault in tipc_conn_delete_sub

2020-07-27 Thread Greg KH
On Mon, Jul 27, 2020 at 07:46:05PM +0530, B K Karthik wrote: > On Mon, Jul 27, 2020 at 6:53 PM Greg KH wrote: > > > > On Mon, Jul 27, 2020 at 06:40:57PM +0530, B K Karthik wrote: > > > fix a general protection fault in tipc_conn_delete_sub > > > by checking for the existance of con->server. > > >

Re: [PATCH] net: tipc: fix general protection fault in tipc_conn_delete_sub

2020-07-27 Thread kernel test robot
Hi K, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.8-rc7 next-20200724] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

Re: [PATCH] net: tipc: fix general protection fault in tipc_conn_delete_sub

2020-07-27 Thread B K Karthik
On Mon, Jul 27, 2020 at 6:53 PM Greg KH wrote: > > On Mon, Jul 27, 2020 at 06:40:57PM +0530, B K Karthik wrote: > > fix a general protection fault in tipc_conn_delete_sub > > by checking for the existance of con->server. > > prevent a null-ptr-deref by returning -EINVAL when > > con->server is NUL

Re: [PATCH] net: tipc: fix general protection fault in tipc_conn_delete_sub

2020-07-27 Thread Greg KH
On Mon, Jul 27, 2020 at 06:40:57PM +0530, B K Karthik wrote: > fix a general protection fault in tipc_conn_delete_sub > by checking for the existance of con->server. > prevent a null-ptr-deref by returning -EINVAL when > con->server is NULL > > general protection fault, probably for non-canonical

[PATCH] net: tipc: fix general protection fault in tipc_conn_delete_sub

2020-07-27 Thread B K Karthik
fix a general protection fault in tipc_conn_delete_sub by checking for the existance of con->server. prevent a null-ptr-deref by returning -EINVAL when con->server is NULL general protection fault, probably for non-canonical address 0xdc14: [#1] PREEMPT SMP KASAN KASAN: null-ptr-