Re: [PATCH] net: stop endless flood about dst entry refcount underflow or overflow

2015-07-14 Thread David Miller
From: Eric Dumazet Date: Tue, 14 Jul 2015 14:26:07 +0200 > On Tue, 2015-07-14 at 15:15 +0300, Konstantin Khlebnikov wrote: > >> Simple warn-once will hide a lot of information which could be useful. >> Also dst entry leak is better than freeing actually active entry. > > Then BUG_ON() . > > Re

Re: [PATCH] net: stop endless flood about dst entry refcount underflow or overflow

2015-07-14 Thread Eric Dumazet
On Tue, 2015-07-14 at 15:15 +0300, Konstantin Khlebnikov wrote: > Simple warn-once will hide a lot of information which could be useful. > Also dst entry leak is better than freeing actually active entry. Then BUG_ON() . Really, we need to fix leaks, not brown paper them. -- To unsubscribe fr

Re: [PATCH] net: stop endless flood about dst entry refcount underflow or overflow

2015-07-14 Thread Konstantin Khlebnikov
On 14.07.2015 15:04, Eric Dumazet wrote: On Tue, 2015-07-14 at 14:43 +0300, Konstantin Khlebnikov wrote: Kernel generates a lot of warnings when dst entry reference counter overflows and becomes negative. This patch prints address of dst entry, its refcount and then resets reference counter to I

Re: [PATCH] net: stop endless flood about dst entry refcount underflow or overflow

2015-07-14 Thread Eric Dumazet
On Tue, 2015-07-14 at 14:43 +0300, Konstantin Khlebnikov wrote: > Kernel generates a lot of warnings when dst entry reference counter > overflows and becomes negative. This patch prints address of dst entry, > its refcount and then resets reference counter to INT_MAX/2. > > That bug was seen sever

[PATCH] net: stop endless flood about dst entry refcount underflow or overflow

2015-07-14 Thread Konstantin Khlebnikov
Kernel generates a lot of warnings when dst entry reference counter overflows and becomes negative. This patch prints address of dst entry, its refcount and then resets reference counter to INT_MAX/2. That bug was seen several times at machines with outdated 3.10.y kernels. Most like it's already