Re: [PATCH] net: stmmac: Fix RX Coalesce IOC always true issue

2020-06-09 Thread biao huang
On Tue, 2020-06-09 at 14:20 +, Jose Abreu wrote: > From: Biao Huang > Date: Jun/09/2020, 10:41:33 (UTC+00:00) > > > - rx_q->rx_count_frames += priv->rx_coal_frames; > > - if (rx_q->rx_count_frames > priv->rx_coal_frames) > > + if (rx_q->rx_count_frames >= priv->r

RE: [PATCH] net: stmmac: Fix RX Coalesce IOC always true issue

2020-06-09 Thread Jose Abreu
From: Biao Huang Date: Jun/09/2020, 10:41:33 (UTC+00:00) > - rx_q->rx_count_frames += priv->rx_coal_frames; > - if (rx_q->rx_count_frames > priv->rx_coal_frames) > + if (rx_q->rx_count_frames >= priv->rx_coal_frames) This is no right. If you want to RX IC bit

[PATCH] net: stmmac: Fix RX Coalesce IOC always true issue

2020-06-09 Thread Biao Huang
Currently rx_count_frames in stmmac_rx_refill always 0, which leads to use_rx_wd false, and IOC bit of rx_desc3 true forever. Fix it. Fixes: 6fa9d691b91ac ("net: stmmac: Prevent divide-by-zero") Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +-- 1 file chang