Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread David Miller
From: Kees Cook Date: Tue, 1 May 2018 14:01:30 -0700 > In the quest to remove all stack VLAs from the kernel[1], this switches > the "status" stack buffer to use the existing small (8) upper bound on > how many queues can be checked for DMA, and adds a sanity-check just to > make sure it doesn't

Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread Alexandre Torgue
On 05/02/2018 04:07 PM, Jose Abreu wrote: On 02-05-2018 13:36, Kees Cook wrote: On Wed, May 2, 2018 at 1:54 AM, Jose Abreu wrote: Hi Kees, On 01-05-2018 22:01, Kees Cook wrote: In the quest to remove all stack VLAs from the kernel[1], this switches the "status" stack buffer to use the ex

Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread Jose Abreu
On 02-05-2018 13:36, Kees Cook wrote: > On Wed, May 2, 2018 at 1:54 AM, Jose Abreu wrote: >> Hi Kees, >> >> On 01-05-2018 22:01, Kees Cook wrote: >>> In the quest to remove all stack VLAs from the kernel[1], this switches >>> the "status" stack buffer to use the existing small (8) upper bound on

Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread Kees Cook
On Wed, May 2, 2018 at 1:54 AM, Jose Abreu wrote: > Hi Kees, > > On 01-05-2018 22:01, Kees Cook wrote: >> In the quest to remove all stack VLAs from the kernel[1], this switches >> the "status" stack buffer to use the existing small (8) upper bound on >> how many queues can be checked for DMA, and

Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread Jose Abreu
Hi Kees, On 01-05-2018 22:01, Kees Cook wrote: > In the quest to remove all stack VLAs from the kernel[1], this switches > the "status" stack buffer to use the existing small (8) upper bound on > how many queues can be checked for DMA, and adds a sanity-check just to > make sure it doesn't operate

[PATCH] net: stmmac: Avoid VLA usage

2018-05-01 Thread Kees Cook
In the quest to remove all stack VLAs from the kernel[1], this switches the "status" stack buffer to use the existing small (8) upper bound on how many queues can be checked for DMA, and adds a sanity-check just to make sure it doesn't operate under pathological conditions. [1] http://lkml.kernel