Re: [PATCH] net: smsc911x: Fix unload crash when link is up

2018-03-07 Thread David Miller
From: Jeremy Linton Date: Tue, 6 Mar 2018 09:00:06 -0600 > The smsc911x driver will crash if it is rmmod'ed while the netdev > is up like: > > Call trace: ... > This is caused by the mdiobus being unregistered/free'd > and the code in phy_detach() attempting to manipulate mdio > related struct

Re: [PATCH] net: smsc911x: Fix unload crash when link is up

2018-03-06 Thread Jeremy Linton
Hi, On 03/06/2018 09:23 AM, Andrew Lunn wrote: This is caused by the mdiobus being unregistered/free'd and the code in phy_detach() attempting to manipulate mdio related structures from unregister_netdev() calling close() To fix this, we delay the mdiobus teardown until after the netdev is dere

Re: [PATCH] net: smsc911x: Fix unload crash when link is up

2018-03-06 Thread Andrew Lunn
> This is caused by the mdiobus being unregistered/free'd > and the code in phy_detach() attempting to manipulate mdio > related structures from unregister_netdev() calling close() > > To fix this, we delay the mdiobus teardown until after > the netdev is deregistered. > > Reported-by: Matt Seale

[PATCH] net: smsc911x: Fix unload crash when link is up

2018-03-06 Thread Jeremy Linton
The smsc911x driver will crash if it is rmmod'ed while the netdev is up like: Call trace: phy_detach+0x94/0x150 phy_disconnect+0x40/0x50 smsc911x_stop+0x104/0x128 [smsc911x] __dev_close_many+0xb4/0x138 dev_close_many+0xbc/0x190 rollback_registered_many+0x140/0x460 rollback_registered