Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available

2017-12-04 Thread Andrew Lunn
> >diff --git a/drivers/net/ethernet/renesas/sh_eth.c > >b/drivers/net/ethernet/renesas/sh_eth.c > >index db72d13cebb9..0074c5998481 100644 > >--- a/drivers/net/ethernet/renesas/sh_eth.c > >+++ b/drivers/net/ethernet/renesas/sh_eth.c > >@@ -1892,6 +1892,11 @@ static int sh_eth_phy_init(struct net_

Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available

2017-12-04 Thread Sergei Shtylyov
On 12/04/2017 05:13 PM, Thomas Petazzoni wrote: Not all variants of the sh_eth hardware have Gigabit support. Unfortunately, the current driver doesn't update phydev->supported depending on the MAC capabilities. Due to this, if you have a Gigabit capable PHY, the PHY will advertise its Gigabit c

Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available

2017-12-04 Thread Sergei Shtylyov
Hello! On 12/04/2017 05:13 PM, Thomas Petazzoni wrote: Not all variants of the sh_eth hardware have Gigabit support. Unfortunately, the current driver doesn't update phydev->supported depending on the MAC capabilities. Due to this, if you have a Gigabit capable PHY, the PHY will advertise its G

Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available

2017-12-04 Thread Andrew Lunn
On Mon, Dec 04, 2017 at 03:13:46PM +0100, Thomas Petazzoni wrote: > Not all variants of the sh_eth hardware have Gigabit > support. Unfortunately, the current driver doesn't update > phydev->supported depending on the MAC capabilities. Due to this, if > you have a Gigabit capable PHY, the PHY will

[PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available

2017-12-04 Thread Thomas Petazzoni
Not all variants of the sh_eth hardware have Gigabit support. Unfortunately, the current driver doesn't update phydev->supported depending on the MAC capabilities. Due to this, if you have a Gigabit capable PHY, the PHY will advertise its Gigabit capability and establish a link at 1Gbit/s, even tho