Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

2020-12-08 Thread Loic Poulain
Hi Subash, On Tue, 8 Dec 2020 at 09:19, wrote: > > >> What about just returning an error on NETDEV_PRECHANGEMTU notification > >> to prevent real device MTU change while virtual rmnet devices are > >> linked? Not sure there is a more proper and thread safe way to manager > >> that otherwise. > >

Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

2020-12-08 Thread subashab
What about just returning an error on NETDEV_PRECHANGEMTU notification to prevent real device MTU change while virtual rmnet devices are linked? Not sure there is a more proper and thread safe way to manager that otherwise. Can't you copy what vlan devices do? That'd seem like a reasonable and

Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 17:45:17 +0100 Loic Poulain wrote: > > This would need similar checks in the NETDEV_PRECHANGEMTU > > netdev notifier. > > What about just returning an error on NETDEV_PRECHANGEMTU notification > to prevent real device MTU change while virtual rmnet devices are > linked? Not su

Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

2020-12-07 Thread Loic Poulain
Hi Subash, On Fri, 4 Dec 2020 at 22:56, wrote: > > On 2020-12-03 10:40, Loic Poulain wrote: > > A submitted qmap/rmnet packet size can not be larger than the linked > > interface (real_dev) MTU. This patch ensures that the rmnet virtual > > iface MTU is configured according real device capability

Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

2020-12-04 Thread subashab
On 2020-12-03 10:40, Loic Poulain wrote: A submitted qmap/rmnet packet size can not be larger than the linked interface (real_dev) MTU. This patch ensures that the rmnet virtual iface MTU is configured according real device capability. Signed-off-by: Loic Poulain --- drivers/net/ethernet/qualc

[PATCH] net: rmnet: Adjust virtual device MTU on real device capability

2020-12-03 Thread Loic Poulain
A submitted qmap/rmnet packet size can not be larger than the linked interface (real_dev) MTU. This patch ensures that the rmnet virtual iface MTU is configured according real device capability. Signed-off-by: Loic Poulain --- drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 8 1 file