Re: [PATCH] net: qrtr: ns: Fix the incorrect usage of rcu_read_lock()

2020-10-02 Thread Manivannan Sadhasivam
Hi Doug, On Fri, Oct 02, 2020 at 08:28:51AM -0700, Doug Anderson wrote: > Hi, > > On Fri, Oct 2, 2020 at 7:15 AM Manivannan Sadhasivam > wrote: > > > > The rcu_read_lock() is not supposed to lock the kernel_sendmsg() API > > since it has the lock_sock() in qrtr_sendmsg() which will sleep. Hence,

Re: [PATCH] net: qrtr: ns: Fix the incorrect usage of rcu_read_lock()

2020-10-02 Thread Doug Anderson
Hi, On Fri, Oct 2, 2020 at 7:15 AM Manivannan Sadhasivam wrote: > > The rcu_read_lock() is not supposed to lock the kernel_sendmsg() API > since it has the lock_sock() in qrtr_sendmsg() which will sleep. Hence, > fix it by excluding the locking for kernel_sendmsg(). > > Fixes: a7809ff90ce6 ("net:

[PATCH] net: qrtr: ns: Fix the incorrect usage of rcu_read_lock()

2020-10-02 Thread Manivannan Sadhasivam
The rcu_read_lock() is not supposed to lock the kernel_sendmsg() API since it has the lock_sock() in qrtr_sendmsg() which will sleep. Hence, fix it by excluding the locking for kernel_sendmsg(). Fixes: a7809ff90ce6 ("net: qrtr: ns: Protect radix_tree_deref_slot() using rcu read locks") Reported-b