Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-06-21 Thread Heiner Kallweit
On 17.06.2020 11:09, Jisheng Zhang wrote: > On Fri, 15 May 2020 19:30:38 +0200 Heiner Kallweit wrote: > > >> >> >> On 15.05.2020 18:18, Florian Fainelli wrote: >>> >>> >>> On 5/15/2020 12:41 AM, Jisheng Zhang wrote: On Thu, 14 May 2020 21:50:53 +0200 Heiner Kallweit wrote: > >>>

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-06-17 Thread Jisheng Zhang
On Fri, 15 May 2020 19:30:38 +0200 Heiner Kallweit wrote: > > > On 15.05.2020 18:18, Florian Fainelli wrote: > > > > > > On 5/15/2020 12:41 AM, Jisheng Zhang wrote: > >> On Thu, 14 May 2020 21:50:53 +0200 Heiner Kallweit wrote: > >> > >>> > >>> > >>> On 14.05.2020 08:25, Jisheng Zhang wrote

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-15 Thread Heiner Kallweit
On 15.05.2020 18:18, Florian Fainelli wrote: > > > On 5/15/2020 12:41 AM, Jisheng Zhang wrote: >> On Thu, 14 May 2020 21:50:53 +0200 Heiner Kallweit wrote: >> >>> >>> >>> On 14.05.2020 08:25, Jisheng Zhang wrote: On Wed, 13 May 2020 20:45:13 +0200 Heiner Kallweit wrote: > > On

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-15 Thread Florian Fainelli
On 5/15/2020 12:41 AM, Jisheng Zhang wrote: > On Thu, 14 May 2020 21:50:53 +0200 Heiner Kallweit wrote: > >> >> >> On 14.05.2020 08:25, Jisheng Zhang wrote: >>> On Wed, 13 May 2020 20:45:13 +0200 Heiner Kallweit wrote: >>> On 13.05.2020 08:51, Jisheng Zhang wrote: > Hi, >

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-15 Thread Jisheng Zhang
On Thu, 14 May 2020 21:50:53 +0200 Heiner Kallweit wrote: > > > On 14.05.2020 08:25, Jisheng Zhang wrote: > > On Wed, 13 May 2020 20:45:13 +0200 Heiner Kallweit wrote: > > > >> > >> On 13.05.2020 08:51, Jisheng Zhang wrote: > >>> Hi, > >>> > >>> On Tue, 12 May 2020 20:43:40 +0200 Heiner Kall

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-14 Thread Heiner Kallweit
On 14.05.2020 08:25, Jisheng Zhang wrote: > On Wed, 13 May 2020 20:45:13 +0200 Heiner Kallweit wrote: > >> >> On 13.05.2020 08:51, Jisheng Zhang wrote: >>> Hi, >>> >>> On Tue, 12 May 2020 20:43:40 +0200 Heiner Kallweit wrote: >>> On 12.05.2020 12:46, Jisheng Zhang wrote: > T

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-13 Thread Jisheng Zhang
On Wed, 13 May 2020 20:45:13 +0200 Heiner Kallweit wrote: > > On 13.05.2020 08:51, Jisheng Zhang wrote: > > Hi, > > > > On Tue, 12 May 2020 20:43:40 +0200 Heiner Kallweit wrote: > > > >> > >> > >> On 12.05.2020 12:46, Jisheng Zhang wrote: > >>> The PHY Register Accessible Interrupt is enabled

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-13 Thread Heiner Kallweit
On 13.05.2020 08:51, Jisheng Zhang wrote: > Hi, > > On Tue, 12 May 2020 20:43:40 +0200 Heiner Kallweit wrote: > >> >> >> On 12.05.2020 12:46, Jisheng Zhang wrote: >>> The PHY Register Accessible Interrupt is enabled by default, so >>> there's such an interrupt during init. In PHY POLL mode case,

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-12 Thread Jisheng Zhang
Hi, On Tue, 12 May 2020 20:43:40 +0200 Heiner Kallweit wrote: > > > On 12.05.2020 12:46, Jisheng Zhang wrote: > > The PHY Register Accessible Interrupt is enabled by default, so > > there's such an interrupt during init. In PHY POLL mode case, the > > INTB/PMEB pin is alway active, it is not go

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-12 Thread Heiner Kallweit
On 12.05.2020 12:46, Jisheng Zhang wrote: > The PHY Register Accessible Interrupt is enabled by default, so > there's such an interrupt during init. In PHY POLL mode case, the > INTB/PMEB pin is alway active, it is not good. Clear the interrupt by > calling rtl8211f_ack_interrupt(). As you say "it

[PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-12 Thread Jisheng Zhang
The PHY Register Accessible Interrupt is enabled by default, so there's such an interrupt during init. In PHY POLL mode case, the INTB/PMEB pin is alway active, it is not good. Clear the interrupt by calling rtl8211f_ack_interrupt(). Signed-off-by: Jisheng Zhang --- drivers/net/phy/realtek.c | 4