Re: [PATCH] net: phy: realtek: Dummy IRQ calls for RTL8366RB

2019-02-23 Thread Linus Walleij
On Sun, Feb 24, 2019 at 1:07 AM Andrew Lunn wrote: > > They are handled by the irqchip mask/unmask inside > > the RTL8366RB, see: > > drivers/net/dsa/rtl8366rb.c > > > > So as soon as the phy core request the threaded IRQ > > the irqchip will deal with this business on its own. > > > > How exactl

Re: [PATCH] net: phy: realtek: Dummy IRQ calls for RTL8366RB

2019-02-23 Thread Andrew Lunn
> They are handled by the irqchip mask/unmask inside > the RTL8366RB, see: > drivers/net/dsa/rtl8366rb.c > > So as soon as the phy core request the threaded IRQ > the irqchip will deal with this business on its own. > > How exactly the RTL8366RB IRQ machine looks inside > I doubt even Realtek kno

Re: [PATCH] net: phy: realtek: Dummy IRQ calls for RTL8366RB

2019-02-23 Thread Linus Walleij
On Sat, Feb 23, 2019 at 4:17 PM Andrew Lunn wrote: > On Sat, Feb 23, 2019 at 03:36:39AM +0100, Linus Walleij wrote: > > This fixes a regression introduced by > > commit 0d2e778e38e0ddffab4bb2b0e9ed2ad5165c4bf7 > > "net: phy: replace PHY_HAS_INTERRUPT with a check for > > config_intr and ack_inter

Re: [PATCH] net: phy: realtek: Dummy IRQ calls for RTL8366RB

2019-02-23 Thread Andrew Lunn
On Sat, Feb 23, 2019 at 03:36:39AM +0100, Linus Walleij wrote: > This fixes a regression introduced by > commit 0d2e778e38e0ddffab4bb2b0e9ed2ad5165c4bf7 > "net: phy: replace PHY_HAS_INTERRUPT with a check for > config_intr and ack_interrupt". > > This assumes that a PHY cannot trigger interrupt un

Re: [PATCH] net: phy: realtek: Dummy IRQ calls for RTL8366RB

2019-02-23 Thread Heiner Kallweit
On 23.02.2019 03:36, Linus Walleij wrote: > This fixes a regression introduced by > commit 0d2e778e38e0ddffab4bb2b0e9ed2ad5165c4bf7 > "net: phy: replace PHY_HAS_INTERRUPT with a check for > config_intr and ack_interrupt". > > This assumes that a PHY cannot trigger interrupt unless > it has .config

[PATCH] net: phy: realtek: Dummy IRQ calls for RTL8366RB

2019-02-22 Thread Linus Walleij
This fixes a regression introduced by commit 0d2e778e38e0ddffab4bb2b0e9ed2ad5165c4bf7 "net: phy: replace PHY_HAS_INTERRUPT with a check for config_intr and ack_interrupt". This assumes that a PHY cannot trigger interrupt unless it has .config_intr() or .ack_interrupt() implemented. A later patch m