Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-02-11 Thread Pavel Machek
On Thu 2021-02-11 13:36:16, Heiner Kallweit wrote: > On 11.02.2021 13:17, Pavel Machek wrote: > > On Thu 2021-01-14 12:05:21, Heiner Kallweit wrote: > >> On 14.01.2021 11:41, claudiu.bez...@microchip.com wrote: > >>> > >>> > >>> On 14.01.2021 12:25, Russell King - ARM Linux admin wrote: > > >>

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-02-11 Thread Claudiu.Beznea
Hi, Rafael, Pavel, I know you may be busy. Just a gentle ping on this topic. It would be nice to have your input in this. Thank you, Claudiu Beznea On 14.01.2021 13:05, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-02-11 Thread Heiner Kallweit
On 11.02.2021 13:17, Pavel Machek wrote: > On Thu 2021-01-14 12:05:21, Heiner Kallweit wrote: >> On 14.01.2021 11:41, claudiu.bez...@microchip.com wrote: >>> >>> >>> On 14.01.2021 12:25, Russell King - ARM Linux admin wrote: As I've said, if phylib/PHY driver is not restoring the state of

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-02-11 Thread Pavel Machek
On Thu 2021-01-14 12:05:21, Heiner Kallweit wrote: > On 14.01.2021 11:41, claudiu.bez...@microchip.com wrote: > > > > > > On 14.01.2021 12:25, Russell King - ARM Linux admin wrote: > >> > >> As I've said, if phylib/PHY driver is not restoring the state of the > >> PHY on resume from suspend-to-ra

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-14 Thread Claudiu.Beznea
On 14.01.2021 12:25, Russell King - ARM Linux admin wrote: > > As I've said, if phylib/PHY driver is not restoring the state of the > PHY on resume from suspend-to-ram, then that's an issue with phylib > and/or the phy driver. In the patch I proposed in this thread the restoring is done in PHY

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-14 Thread Claudiu.Beznea
Hi, Rafael, Pavel, I recently posted a patch for re-configuring an ethernet PHY on its .resume() callback as this PHY is in a setup with SAMA7G5 SoC that supports a power saving mode (called backup). In this power saving mode most of the SoC devices' power is cut of (except the RAM + its controlle

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-14 Thread Heiner Kallweit
On 14.01.2021 11:41, claudiu.bez...@microchip.com wrote: > > > On 14.01.2021 12:25, Russell King - ARM Linux admin wrote: >> >> As I've said, if phylib/PHY driver is not restoring the state of the >> PHY on resume from suspend-to-ram, then that's an issue with phylib >> and/or the phy driver. >

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-14 Thread Russell King - ARM Linux admin
On Thu, Jan 14, 2021 at 10:12:13AM +, claudiu.bez...@microchip.com wrote: > Up to this moment we treat this backup mode as S2R mode since the memory > was kept in self-refresh mode. Each driver was saving/restoring in/from RAM > the content of associated registers in the suspend/resume phase.

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Heiner Kallweit
On 13.01.2021 23:01, Russell King - ARM Linux admin wrote: > On Wed, Jan 13, 2021 at 10:34:53PM +0100, Heiner Kallweit wrote: >> On 13.01.2021 13:36, claudiu.bez...@microchip.com wrote: >>> On 13.01.2021 13:09, Heiner Kallweit wrote: On 13.01.2021 10:29, claudiu.bez...@microchip.com wrote: >>>

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Russell King - ARM Linux admin
On Wed, Jan 13, 2021 at 10:34:53PM +0100, Heiner Kallweit wrote: > On 13.01.2021 13:36, claudiu.bez...@microchip.com wrote: > > On 13.01.2021 13:09, Heiner Kallweit wrote: > >> On 13.01.2021 10:29, claudiu.bez...@microchip.com wrote: > >>> It could enter in this mode based on request for standby or

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Jakub Kicinski
On Fri, 8 Jan 2021 17:45:54 +0200 Claudiu Beznea wrote: > KSZ9131 is used in setups with SAMA7G5. SAMA7G5 supports a special > power saving mode (backup mode) that cuts the power for almost all > parts of the SoC. The rail powering the ethernet PHY is also cut off. > When resuming, in case the PHY

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Heiner Kallweit
On 13.01.2021 13:36, claudiu.bez...@microchip.com wrote: > > > On 13.01.2021 13:09, Heiner Kallweit wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On 13.01.2021 10:29, claudiu.bez...@microchip.com wrote: >>> Hi Heiner, >>> >>> On 08.

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Claudiu.Beznea
On 13.01.2021 13:09, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 13.01.2021 10:29, claudiu.bez...@microchip.com wrote: >> Hi Heiner, >> >> On 08.01.2021 18:31, Heiner Kallweit wrote: >>> EXTERNAL EMAIL: Do not clic

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Claudiu.Beznea
Hi Heiner, On 08.01.2021 18:31, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 08.01.2021 16:45, Claudiu Beznea wrote: >> KSZ9131 is used in setups with SAMA7G5. SAMA7G5 supports a special >> power saving mode (backup

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Heiner Kallweit
On 13.01.2021 10:29, claudiu.bez...@microchip.com wrote: > Hi Heiner, > > On 08.01.2021 18:31, Heiner Kallweit wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On 08.01.2021 16:45, Claudiu Beznea wrote: >>> KSZ9131 is used in setups wit

[PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-08 Thread Claudiu Beznea
KSZ9131 is used in setups with SAMA7G5. SAMA7G5 supports a special power saving mode (backup mode) that cuts the power for almost all parts of the SoC. The rail powering the ethernet PHY is also cut off. When resuming, in case the PHY has been configured on probe with slew rate or DLL settings thes

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-08 Thread Heiner Kallweit
On 08.01.2021 16:45, Claudiu Beznea wrote: > KSZ9131 is used in setups with SAMA7G5. SAMA7G5 supports a special > power saving mode (backup mode) that cuts the power for almost all > parts of the SoC. The rail powering the ethernet PHY is also cut off. > When resuming, in case the PHY has been conf

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-08 Thread Andrew Lunn
On Fri, Jan 08, 2021 at 05:45:54PM +0200, Claudiu Beznea wrote: > KSZ9131 is used in setups with SAMA7G5. SAMA7G5 supports a special > power saving mode (backup mode) that cuts the power for almost all > parts of the SoC. The rail powering the ethernet PHY is also cut off. > When resuming, in case