RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Joakim Zhang
linux-imx > ; Florian Fainelli > Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume > back > > On 07.04.2021 12:05, Joakim Zhang wrote: > > > > Hi Heiner, > > > >> -Original Message- > >> From: Joakim Zhang

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Heiner Kallweit
t.net; >> k...@kernel.org >> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx >> ; Florian Fainelli >> Subject: RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume >> back >> >> >> Hi Heiner, >> >>>

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Joakim Zhang
nel.org; dl-linux-imx > ; Florian Fainelli > Subject: RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume > back > > > Hi Heiner, > > > -Original Message- > > From: Heiner Kallweit > > Sent: 2021年4月7日 15:12 > > To:

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Joakim Zhang
nel.org; dl-linux-imx > ; Florian Fainelli > Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume > back > > On 07.04.2021 03:43, Joakim Zhang wrote: > > > > Hi Heiner, > > > >> -Original Message- > >> From: Heiner Kallw

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Heiner Kallweit
gt; k...@kernel.org; Russell King - ARM Linux >> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx >> ; Florian Fainelli >> Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume >> back >> >> On 06.

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Joakim Zhang
kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > ; Florian Fainelli > Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume > back > > On 06.04.2021 13:42, Heiner Kallweit wrote: > > On 06.04.2021 12:07, Joakim Zhang wrote: > >> > >>> ---

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Florian Fainelli
On 4/6/2021 11:43 AM, Heiner Kallweit wrote: > On 06.04.2021 20:32, Florian Fainelli wrote: >> >> >> On 4/6/2021 4:42 AM, Heiner Kallweit wrote: >>> >>> Waiting for ANEG_COMPLETE to be set wouldn't be a good option. Aneg may >>> never >>> complete for different reasons, e.g. no physical link. A

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Heiner Kallweit
On 06.04.2021 20:32, Florian Fainelli wrote: > > > On 4/6/2021 4:42 AM, Heiner Kallweit wrote: >> >> Waiting for ANEG_COMPLETE to be set wouldn't be a good option. Aneg may never >> complete for different reasons, e.g. no physical link. And even if we use a >> timeout this may add unwanted delays

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Florian Fainelli
On 4/6/2021 4:42 AM, Heiner Kallweit wrote: > > Waiting for ANEG_COMPLETE to be set wouldn't be a good option. Aneg may never > complete for different reasons, e.g. no physical link. And even if we use a > timeout this may add unwanted delays. > >> Do you have any other insights that can help

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Heiner Kallweit
.ch; li...@armlinux.org.uk; da...@davemloft.net; >>> k...@kernel.org >>> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx >>> >>> Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume >>> back >>> >&g

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Heiner Kallweit
gt;> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx >> >> Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume >> back >> >> On 06.04.2021 04:07, Joakim Zhang wrote: >>> >>> Hi Heiner, >&

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Joakim Zhang
-imx > > Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume > back > > On 06.04.2021 04:07, Joakim Zhang wrote: > > > > Hi Heiner, > > > >> -Original Message- > >> From: Heiner Kallweit > >> Sent: 2021年4

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Heiner Kallweit
t.net; >> k...@kernel.org >> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx >> >> Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume >> back >> >> On 05.04.2021 10:43, Christian Melki wrote: >>> On 4/5/21

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
nel.org; dl-linux-imx > > Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume > back > > On 05.04.2021 10:43, Christian Melki wrote: > > On 4/5/21 12:48 AM, Heiner Kallweit wrote: > >> On 04.04.2021 16:09, Heiner Kallweit wrote: > >

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
nel.org; dl-linux-imx > > Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume > back > > On 4/5/21 12:48 AM, Heiner Kallweit wrote: > > On 04.04.2021 16:09, Heiner Kallweit wrote: > >> On 04.04.2021 12:07, Joakim Zhang wrote: > >>> com

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
tian.me...@t2data.com > Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume > back > > On 04.04.2021 16:09, Heiner Kallweit wrote: > > On 04.04.2021 12:07, Joakim Zhang wrote: > >> commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cut

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Joakim Zhang
.org; dl-linux-imx > ; christian.me...@t2data.com > Subject: Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume > back > > On 04.04.2021 12:07, Joakim Zhang wrote: > > commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cut off > > PHY power&quo

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Florian Fainelli
On 4/5/2021 7:58 AM, Heiner Kallweit wrote: > On 05.04.2021 15:53, Christian Melki wrote: >> On 4/5/21 2:09 PM, Heiner Kallweit wrote: >>> On 05.04.2021 10:43, Christian Melki wrote: On 4/5/21 12:48 AM, Heiner Kallweit wrote: > On 04.04.2021 16:09, Heiner Kallweit wrote: >> On 04.04

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Heiner Kallweit
On 05.04.2021 15:53, Christian Melki wrote: > On 4/5/21 2:09 PM, Heiner Kallweit wrote: >> On 05.04.2021 10:43, Christian Melki wrote: >>> On 4/5/21 12:48 AM, Heiner Kallweit wrote: On 04.04.2021 16:09, Heiner Kallweit wrote: > On 04.04.2021 12:07, Joakim Zhang wrote: >> commit 4c0d2e9

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Christian Melki
On 4/5/21 2:09 PM, Heiner Kallweit wrote: > On 05.04.2021 10:43, Christian Melki wrote: >> On 4/5/21 12:48 AM, Heiner Kallweit wrote: >>> On 04.04.2021 16:09, Heiner Kallweit wrote: On 04.04.2021 12:07, Joakim Zhang wrote: > commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cu

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Heiner Kallweit
On 05.04.2021 10:43, Christian Melki wrote: > On 4/5/21 12:48 AM, Heiner Kallweit wrote: >> On 04.04.2021 16:09, Heiner Kallweit wrote: >>> On 04.04.2021 12:07, Joakim Zhang wrote: commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cut off PHY power") invokes phy_init_hw() whe

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Christian Melki
On 4/5/21 12:48 AM, Heiner Kallweit wrote: > On 04.04.2021 16:09, Heiner Kallweit wrote: >> On 04.04.2021 12:07, Joakim Zhang wrote: >>> commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cut >>> off PHY power") invokes phy_init_hw() when MDIO bus resume, it will >>> soft reset PHY if P

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-04 Thread Heiner Kallweit
On 04.04.2021 16:09, Heiner Kallweit wrote: > On 04.04.2021 12:07, Joakim Zhang wrote: >> commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cut >> off PHY power") invokes phy_init_hw() when MDIO bus resume, it will >> soft reset PHY if PHY driver implements soft_reset callback. >> comm

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-04 Thread Heiner Kallweit
On 04.04.2021 12:07, Joakim Zhang wrote: > commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cut > off PHY power") invokes phy_init_hw() when MDIO bus resume, it will > soft reset PHY if PHY driver implements soft_reset callback. > commit 764d31cacfe4 ("net: phy: micrel: set soft_reset

[PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-04 Thread Joakim Zhang
commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cut off PHY power") invokes phy_init_hw() when MDIO bus resume, it will soft reset PHY if PHY driver implements soft_reset callback. commit 764d31cacfe4 ("net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081") adds