Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Russell King - ARM Linux admin
On Wed, Oct 14, 2020 at 04:39:47PM +0200, Lukasz Stelmach wrote: > It was <2020-10-14 śro 14:32>, when Russell King - ARM Linux admin wrote: > > In any case, the mii.c code does fill in the advertising mask even > > when autoneg is disabled, because, rightly or wrongly, the advertising > > mask con

Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Lukasz Stelmach
It was <2020-10-14 śro 23:04>, when Russell King - ARM Linux admin wrote: > On Wed, Oct 14, 2020 at 04:39:47PM +0200, Lukasz Stelmach wrote: >> It was <2020-10-14 śro 14:32>, when Russell King - ARM Linux admin wrote: >> > In any case, the mii.c code does fill in the advertising mask even >> > when

Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Lukasz Stelmach
It was <2020-10-14 śro 14:32>, when Russell King - ARM Linux admin wrote: > On Wed, Oct 14, 2020 at 02:56:50PM +0200, Łukasz Stelmach wrote: >> Do not report advertised link modes when autonegotiation is turned >> off. mii_ethtool_get_link_ksettings() exhibits the same behaviour. > > Please explain

Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Russell King - ARM Linux admin
On Wed, Oct 14, 2020 at 02:56:50PM +0200, Łukasz Stelmach wrote: > Do not report advertised link modes when autonegotiation is turned > off. mii_ethtool_get_link_ksettings() exhibits the same behaviour. Please explain why this is a desirable change. Referring to some other piece of code isn't a p

[PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Łukasz Stelmach
Do not report advertised link modes when autonegotiation is turned off. mii_ethtool_get_link_ksettings() exhibits the same behaviour. Signed-off-by: Łukasz Stelmach --- drivers/net/phy/phy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy.c b/drivers/net