Re: [PATCH] net: phy: Fix c45 no phy detected logic

2020-05-19 Thread Jeremy Linton
Hi, On 5/14/20 12:00 PM, Jeremy Linton wrote: The commit "disregard Clause 22 registers present bit..." clears the low bit of the devices_in_package data which is being used in get_phy_c45_ids() to determine if a phy/register is responding correctly. That check is against 0x1FFF, but since t

Re: [PATCH] net: phy: Fix c45 no phy detected logic

2020-05-14 Thread Jeremy Linton
Hi, On 5/14/20 2:59 PM, Heiner Kallweit wrote: On 14.05.2020 19:00, Jeremy Linton wrote: The commit "disregard Clause 22 registers present bit..." clears the low bit of the devices_in_package data which is being used in get_phy_c45_ids() to determine if a phy/register is responding correctly. T

Re: [PATCH] net: phy: Fix c45 no phy detected logic

2020-05-14 Thread Heiner Kallweit
On 14.05.2020 19:00, Jeremy Linton wrote: > The commit "disregard Clause 22 registers present bit..." clears > the low bit of the devices_in_package data which is being used > in get_phy_c45_ids() to determine if a phy/register is responding > correctly. That check is against 0x1FFF, but since

[PATCH] net: phy: Fix c45 no phy detected logic

2020-05-14 Thread Jeremy Linton
The commit "disregard Clause 22 registers present bit..." clears the low bit of the devices_in_package data which is being used in get_phy_c45_ids() to determine if a phy/register is responding correctly. That check is against 0x1FFF, but since the low bit is always cleared, the check can never