Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-09-19 Thread Nicolas Ferre
Hi all, I come back to this thread to re-start the conversation as I still have the issue... Le 16/04/2016 à 00:45, Alexandre Belloni a écrit : > On 16/04/2016 at 00:30:26 +0200, Andrew Lunn wrote : >> On Sat, Apr 16, 2016 at 12:17:11AM +0200, Alexandre Belloni wrote: >>> On 16/04/2016 at 00:05:

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-05-19 Thread David Mosberger
On Thu, May 19, 2016 at 10:31 AM, Alexandre Belloni wrote: > On 17/05/2016 at 17:35:30 -0600, David Mosberger wrote : >> At 7.96 seconds, phy_start() gets called, but even though this enters >> state PHY_UP, it does not trigger phy_state_machine() and therefore >> doesn't trigger autonegotiation.

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-05-19 Thread Alexandre Belloni
On 17/05/2016 at 17:35:30 -0600, David Mosberger wrote : > At 7.96 seconds, phy_start() gets called, but even though this enters > state PHY_UP, it does not trigger phy_state_machine() and therefore > doesn't trigger autonegotiation. I'm not quite sure how this is > intended to be handled properly

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-05-17 Thread David Mosberger
[Resending with mailing list address corrected. Sorry about that.] I believe I'm seeing the same issue as in this thread: http://www.spinics.net/lists/netdev/msg373670.html macb Ethernet driver and after upgrading from 4.4.0 to 4.60, the Ethernet interface would not initialize unless I force

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-18 Thread Alexandre Belloni
On 18/04/2016 at 15:17:58 -0700, Florian Fainelli wrote : > Yes, seems like it, how about adding this: > > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c > index 98b99149ce0b..21096dfb0e83 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-18 Thread Florian Fainelli
On 18/04/16 15:14, Alexandre Belloni wrote: > On 15/04/2016 at 15:23:39 -0700, Florian Fainelli wrote : >> On 15/04/16 15:17, Alexandre Belloni wrote: >>> On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote : > Trace without my patch: > libphy: MACB_mii_bus: probed > macb f802.ethern

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-18 Thread Alexandre Belloni
On 15/04/2016 at 15:23:39 -0700, Florian Fainelli wrote : > On 15/04/16 15:17, Alexandre Belloni wrote: > > On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote : > >>> Trace without my patch: > >>> libphy: MACB_mii_bus: probed > >>> macb f802.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf80200

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Alexandre Belloni
On 16/04/2016 at 00:30:26 +0200, Andrew Lunn wrote : > On Sat, Apr 16, 2016 at 12:17:11AM +0200, Alexandre Belloni wrote: > > On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote : > > > > Trace without my patch: > > > > libphy: MACB_mii_bus: probed > > > > macb f802.ethernet eth0: Cadence GEM re

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Andrew Lunn
On Sat, Apr 16, 2016 at 12:17:11AM +0200, Alexandre Belloni wrote: > On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote : > > > Trace without my patch: > > > libphy: MACB_mii_bus: probed > > > macb f802.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf802 irq > > > 27 (fc:c2:3d:0c:6e:05) >

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Florian Fainelli
On 15/04/16 15:17, Alexandre Belloni wrote: > On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote : >>> Trace without my patch: >>> libphy: MACB_mii_bus: probed >>> macb f802.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf802 irq >>> 27 (fc:c2:3d:0c:6e:05) >>> Micrel KSZ8081 or KSZ8091 f80

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Alexandre Belloni
On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote : > > Trace without my patch: > > libphy: MACB_mii_bus: probed > > macb f802.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf802 irq > > 27 (fc:c2:3d:0c:6e:05) > > Micrel KSZ8081 or KSZ8091 f802.etherne:01: attached PHY driver [Micrel

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Andrew Lunn
> Trace without my patch: > libphy: MACB_mii_bus: probed > macb f802.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf802 irq 27 > (fc:c2:3d:0c:6e:05) > Micrel KSZ8081 or KSZ8091 f802.etherne:01: attached PHY driver [Micrel > KSZ8081 or KSZ8091] (mii_bus:phy_addr=f802.etherne:01, i

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Alexandre Belloni
On 15/04/2016 at 13:10:12 -0700, Florian Fainelli wrote : > On 15/04/16 12:56, Alexandre Belloni wrote: > > Commit d5c3d84657db ("net: phy: Avoid polling PHY with > > PHY_IGNORE_INTERRUPTS") removed the last polling done on the phy. Since > > then, the last actual poll done on the phy happens PHY_S

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Florian Fainelli
On 15/04/16 12:56, Alexandre Belloni wrote: > Commit d5c3d84657db ("net: phy: Avoid polling PHY with > PHY_IGNORE_INTERRUPTS") removed the last polling done on the phy. Since > then, the last actual poll done on the phy happens PHY_STATE_TIME seconds > (that is actually one second) after registerin

[PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Alexandre Belloni
Commit d5c3d84657db ("net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS") removed the last polling done on the phy. Since then, the last actual poll done on the phy happens PHY_STATE_TIME seconds (that is actually one second) after registering the phy. If the interface is not UP by that time,