Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning

2020-08-05 Thread Eelco Chaudron
On 5 Aug 2020, at 9:19, xiangxia.m@gmail.com wrote: From: Tonghao Zhang ovs_flow_tbl_destroy always is called from RCU callback or error path. It is no need to check if rcu_read_lock or lockdep_ovsl_is_held was held. ovs_dp_cmd_fill_info always is called with ovs_mutex, So use the rcu_

Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning

2020-08-05 Thread David Miller
From: xiangxia.m@gmail.com Date: Wed, 5 Aug 2020 15:19:11 +0800 > From: Tonghao Zhang > > ovs_flow_tbl_destroy always is called from RCU callback > or error path. It is no need to check if rcu_read_lock > or lockdep_ovsl_is_held was held. > > ovs_dp_cmd_fill_info always is called with ovs_

Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning

2020-08-05 Thread Paolo Abeni
On Wed, 2020-08-05 at 15:19 +0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > ovs_flow_tbl_destroy always is called from RCU callback > or error path. It is no need to check if rcu_read_lock > or lockdep_ovsl_is_held was held. > > ovs_dp_cmd_fill_info always is called with ovs_mut

[PATCH] net: openvswitch: silence suspicious RCU usage warning

2020-08-05 Thread xiangxia . m . yue
From: Tonghao Zhang ovs_flow_tbl_destroy always is called from RCU callback or error path. It is no need to check if rcu_read_lock or lockdep_ovsl_is_held was held. ovs_dp_cmd_fill_info always is called with ovs_mutex, So use the rcu_dereference_ovsl instead of rcu_dereference in ovs_flow_tbl_ma