Re: [PATCH] net: move padding in struct skb_shared_info

2017-04-11 Thread David Miller
From: Alexey Dobriyan Date: Tue, 11 Apr 2017 12:41:08 +0300 > On Mon, Apr 10, 2017 at 5:43 PM, Eric Dumazet wrote: >> On Mon, 2017-04-10 at 11:07 +0300, Alexey Dobriyan wrote: >>> struct skb_shared_info { >>> - unsigned short _unused; >>> unsigned char nr_frags; >>> __u8

Re: [PATCH] net: move padding in struct skb_shared_info

2017-04-11 Thread Eric Dumazet
On Tue, 2017-04-11 at 12:41 +0300, Alexey Dobriyan wrote: > On Mon, Apr 10, 2017 at 5:43 PM, Eric Dumazet wrote: > > On Mon, 2017-04-10 at 11:07 +0300, Alexey Dobriyan wrote: > >> struct skb_shared_info { > >> - unsigned short _unused; > >> unsigned char nr_frags; > >> __u8

Re: [PATCH] net: move padding in struct skb_shared_info

2017-04-11 Thread Alexey Dobriyan
On Mon, Apr 10, 2017 at 5:43 PM, Eric Dumazet wrote: > On Mon, 2017-04-10 at 11:07 +0300, Alexey Dobriyan wrote: >> struct skb_shared_info { >> - unsigned short _unused; >> unsigned char nr_frags; >> __u8tx_flags; >> unsigned short gso_size; > > Nack > > This

Re: [PATCH] net: move padding in struct skb_shared_info

2017-04-10 Thread Eric Dumazet
On Mon, 2017-04-10 at 11:07 +0300, Alexey Dobriyan wrote: > commit 7f564528a480084e2318cd48caba7aef4a54a77f > ("skbuff: Extend gso_type to unsigned int.") created padding as first > field of struct skb_shared_info requiring [R64+imm8] addressing mode > for all fields. > > Patch bubbles up padding

[PATCH] net: move padding in struct skb_shared_info

2017-04-10 Thread Alexey Dobriyan
commit 7f564528a480084e2318cd48caba7aef4a54a77f ("skbuff: Extend gso_type to unsigned int.") created padding as first field of struct skb_shared_info requiring [R64+imm8] addressing mode for all fields. Patch bubbles up padding brinding code size down to original levels and even smaller: