Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-02-02 Thread Andrew Lunn
> > Reviewed-by: Andrew Lunn > > > > Andrew > > Just wondering, now, a v2 patch isn't needed? Or should I amend the commit > text? Hi Mike Take a look in patchwork.kernel.org. It has been flaky the last few days. If the patch is not there, you definitively need to repost. If you do find i

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-02-02 Thread Mike Looijmans
Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijm...@topicproducts.com W: www.topicproducts.com Please consider the environment before printing this e-mail On 2

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-29 Thread Andrew Lunn
On Thu, Jan 28, 2021 at 09:45:41AM +0100, Mike Looijmans wrote: > Hi Andrew, > > Response below... Hi Mike Everybody here knows that top posting is evil, we don't do it. We expect the replay to be inline. > > Hi Mike > > > > Did you look at the per PHY reset? mdiobus_register_gpiod() gets the

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-28 Thread Mike Looijmans
Hi Andrew, Response below... Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijm...@topicproducts.com W: www.topicproducts.com Please consider the environment be

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-27 Thread Andrew Lunn
On Tue, Jan 26, 2021 at 08:33:37AM +0100, Mike Looijmans wrote: > The mdio_bus reset code first de-asserted the reset by allocating with > GPIOD_OUT_LOW, then asserted and de-asserted again. In other words, if > the reset signal defaulted to asserted, there'd be a short "spike" > before the reset.

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-27 Thread Andrew Lunn
On Thu, Jan 28, 2021 at 12:25:55AM +, Russell King - ARM Linux admin wrote: > On Thu, Jan 28, 2021 at 01:00:57AM +0100, Andrew Lunn wrote: > > On Tue, Jan 26, 2021 at 01:49:38PM +, Russell King - ARM Linux admin > > wrote: > > > On Tue, Jan 26, 2021 at 02:14:40PM +0100, Andrew Lunn wrote:

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-27 Thread Russell King - ARM Linux admin
On Thu, Jan 28, 2021 at 01:00:57AM +0100, Andrew Lunn wrote: > On Tue, Jan 26, 2021 at 01:49:38PM +, Russell King - ARM Linux admin > wrote: > > On Tue, Jan 26, 2021 at 02:14:40PM +0100, Andrew Lunn wrote: > > > On Tue, Jan 26, 2021 at 08:33:37AM +0100, Mike Looijmans wrote: > > > > The mdio_b

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-27 Thread Andrew Lunn
On Tue, Jan 26, 2021 at 01:49:38PM +, Russell King - ARM Linux admin wrote: > On Tue, Jan 26, 2021 at 02:14:40PM +0100, Andrew Lunn wrote: > > On Tue, Jan 26, 2021 at 08:33:37AM +0100, Mike Looijmans wrote: > > > The mdio_bus reset code first de-asserted the reset by allocating with > > > GPIOD

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-27 Thread Jakub Kicinski
On Wed, 27 Jan 2021 08:08:29 +0100 Mike Looijmans wrote: > > Andrew, I don't get what you're saying. > > > > Here is what happens depending on the pre-existing state of the > > reset signal: > > > > Reset (previously asserted): ~~~|_||___ > > Reset (previously deasserted): _||

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-26 Thread Mike Looijmans
See below. Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijm...@topicproducts.com W: www.topicproducts.com Please consider the environment before printing this

[PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-26 Thread Mike Looijmans
The mdio_bus reset code first de-asserted the reset by allocating with GPIOD_OUT_LOW, then asserted and de-asserted again. In other words, if the reset signal defaulted to asserted, there'd be a short "spike" before the reset. Instead, directly assert the reset signal using GPIOD_OUT_HIGH, this re

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-26 Thread Russell King - ARM Linux admin
On Tue, Jan 26, 2021 at 02:14:40PM +0100, Andrew Lunn wrote: > On Tue, Jan 26, 2021 at 08:33:37AM +0100, Mike Looijmans wrote: > > The mdio_bus reset code first de-asserted the reset by allocating with > > GPIOD_OUT_LOW, then asserted and de-asserted again. In other words, if > > the reset signal d

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-26 Thread Andrew Lunn
On Tue, Jan 26, 2021 at 08:33:37AM +0100, Mike Looijmans wrote: > The mdio_bus reset code first de-asserted the reset by allocating with > GPIOD_OUT_LOW, then asserted and de-asserted again. In other words, if > the reset signal defaulted to asserted, there'd be a short "spike" > before the reset.