Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 12:02:13PM -0700, Florian Fainelli wrote: > It should not, but that means that when you describe the fixed-link, the > 'phy-mode' within the local fixed-link node is meant to describe how the > other side is configured not how you are configured. For some reason I > did not

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-18 Thread Florian Fainelli
On 6/18/2020 11:49 AM, Russell King - ARM Linux admin wrote: > On Thu, Jun 18, 2020 at 11:06:43AM -0700, Florian Fainelli wrote: >> >> >> On 6/18/2020 1:45 AM, Russell King - ARM Linux admin wrote: >>> On Thu, Jun 18, 2020 at 10:14:33AM +0200, Helmut Grohne wrote: On Wed, Jun 17, 2020 at 02

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 11:06:43AM -0700, Florian Fainelli wrote: > > > On 6/18/2020 1:45 AM, Russell King - ARM Linux admin wrote: > > On Thu, Jun 18, 2020 at 10:14:33AM +0200, Helmut Grohne wrote: > >> On Wed, Jun 17, 2020 at 02:08:09PM +0200, Russell King - ARM Linux admin > >> wrote: > >>> W

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-18 Thread Florian Fainelli
On 6/18/2020 3:01 AM, Russell King - ARM Linux admin wrote: > On Thu, Jun 18, 2020 at 11:05:26AM +0200, Helmut Grohne wrote: >> On Thu, Jun 18, 2020 at 10:45:54AM +0200, Russell King - ARM Linux admin >> wrote: >>> Why do we need that complexity? If we decide that we can allow >>> phy-mode = "

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-18 Thread Florian Fainelli
On 6/17/2020 4:57 AM, Russell King - ARM Linux admin wrote: > On Wed, Jun 17, 2020 at 02:38:25PM +0300, Vladimir Oltean wrote: >> On Wed, 17 Jun 2020 at 14:34, Russell King - ARM Linux admin >> wrote: >>> >> >>> >>> Why are you so abrasive? >>> >>> Not responding to this until you start behavin

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-18 Thread Florian Fainelli
On 6/18/2020 1:45 AM, Russell King - ARM Linux admin wrote: > On Thu, Jun 18, 2020 at 10:14:33AM +0200, Helmut Grohne wrote: >> On Wed, Jun 17, 2020 at 02:08:09PM +0200, Russell King - ARM Linux admin >> wrote: >>> With a fixed link, we could be in either a MAC-to-PHY or MAC-to-MAC >>> setup; w

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 11:05:26AM +0200, Helmut Grohne wrote: > On Thu, Jun 18, 2020 at 10:45:54AM +0200, Russell King - ARM Linux admin > wrote: > > Why do we need that complexity? If we decide that we can allow > > phy-mode = "rgmii" and introduce new properties to control the > > delay, then

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-18 Thread Helmut Grohne
On Thu, Jun 18, 2020 at 10:45:54AM +0200, Russell King - ARM Linux admin wrote: > Why do we need that complexity? If we decide that we can allow > phy-mode = "rgmii" and introduce new properties to control the > delay, then we just need: > > rgmii-tx-delay-ps = ; > rgmii-rx-delay-ps = ; > >

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 10:14:33AM +0200, Helmut Grohne wrote: > On Wed, Jun 17, 2020 at 02:08:09PM +0200, Russell King - ARM Linux admin > wrote: > > With a fixed link, we could be in either a MAC-to-PHY or MAC-to-MAC > > setup; we just don't know. However, we don't have is access to the > > PHY

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-18 Thread Helmut Grohne
On Wed, Jun 17, 2020 at 02:08:09PM +0200, Russell King - ARM Linux admin wrote: > With a fixed link, we could be in either a MAC-to-PHY or MAC-to-MAC > setup; we just don't know. However, we don't have is access to the > PHY (if it exists) in the fixed link case to configure it for the > delay. L

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Nicolas Ferre
On 16/06/2020 at 09:49, Helmut Grohne wrote: The macb driver does not support configuring rgmii delays. At least for the Zynq GEM, delays are not supported by the hardware at all. However, the driver happily accepts and ignores any such delays. When operating in a mac to phy connection, the dela

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 01:52:01PM +0200, Helmut Grohne wrote: > On Wed, Jun 17, 2020 at 01:40:25PM +0200, Russell King - ARM Linux admin > wrote: > > > For a fixed-link, the validation function is never called. Therefore, it > > > cannot reject PHY_INTERFACE_MODE_RGMII. It works in practice. > >

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 02:38:25PM +0300, Vladimir Oltean wrote: > On Wed, 17 Jun 2020 at 14:34, Russell King - ARM Linux admin > wrote: > > > > > > > Why are you so abrasive? > > > > Not responding to this until you start behaving more reasonably. > > > > -- > > RMK's Patch system: https://www.a

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Helmut Grohne
On Wed, Jun 17, 2020 at 01:40:25PM +0200, Russell King - ARM Linux admin wrote: > > For a fixed-link, the validation function is never called. Therefore, it > > cannot reject PHY_INTERFACE_MODE_RGMII. It works in practice. > > Hmm, I'm not so sure, but then I don't know exactly what code you're >

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 01:21:53PM +0200, Helmut Grohne wrote: > On Wed, Jun 17, 2020 at 12:55:18PM +0200, Russell King - ARM Linux admin > wrote: > > The individual RGMII delay modes are more about what the PHY itself is > > asked to do with respect to inserting delays, so I don't think your > >

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Vladimir Oltean
On Wed, 17 Jun 2020 at 14:34, Russell King - ARM Linux admin wrote: > > > Why are you so abrasive? > > Not responding to this until you start behaving more reasonably. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connect

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 02:32:09PM +0300, Vladimir Oltean wrote: > On Wed, 17 Jun 2020 at 13:56, Russell King - ARM Linux admin > wrote: > > > > On Tue, Jun 16, 2020 at 09:49:56AM +0200, Helmut Grohne wrote: > > > The macb driver does not support configuring rgmii delays. At least for > > > the Zy

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Vladimir Oltean
On Wed, 17 Jun 2020 at 13:56, Russell King - ARM Linux admin wrote: > > On Tue, Jun 16, 2020 at 09:49:56AM +0200, Helmut Grohne wrote: > > The macb driver does not support configuring rgmii delays. At least for > > the Zynq GEM, delays are not supported by the hardware at all. However, > > the dri

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Helmut Grohne
On Wed, Jun 17, 2020 at 12:55:18PM +0200, Russell King - ARM Linux admin wrote: > The individual RGMII delay modes are more about what the PHY itself is > asked to do with respect to inserting delays, so I don't think your > patch makes sense. This seems to be the same aspect that Vladimir Oltean

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Helmut Grohne
Hi Vladimir, On Wed, Jun 17, 2020 at 11:57:23AM +0200, Vladimir Oltean wrote: > On Tue, 16 Jun 2020 at 11:00, Helmut Grohne wrote: > > --- a/drivers/net/ethernet/cadence/macb_main.c > > +++ b/drivers/net/ethernet/cadence/macb_main.c > > @@ -514,7 +514,7 @@ static void macb_validate(struct phylink

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Russell King - ARM Linux admin
On Tue, Jun 16, 2020 at 09:49:56AM +0200, Helmut Grohne wrote: > The macb driver does not support configuring rgmii delays. At least for > the Zynq GEM, delays are not supported by the hardware at all. However, > the driver happily accepts and ignores any such delays. > > When operating in a mac t

Re: [PATCH] net: macb: reject unsupported rgmii delays

2020-06-17 Thread Vladimir Oltean
Hi Helmut, On Tue, 16 Jun 2020 at 11:00, Helmut Grohne wrote: > > The macb driver does not support configuring rgmii delays. At least for > the Zynq GEM, delays are not supported by the hardware at all. However, > the driver happily accepts and ignores any such delays. > > When operating in a mac

[PATCH] net: macb: reject unsupported rgmii delays

2020-06-16 Thread Helmut Grohne
The macb driver does not support configuring rgmii delays. At least for the Zynq GEM, delays are not supported by the hardware at all. However, the driver happily accepts and ignores any such delays. When operating in a mac to phy connection, the delay setting applies to the phy. Since the MAC doe