Re: [PATCH] net: macb: Write only necessary bits in NCR in macb reset

2016-11-29 Thread Harini Katakam
Hi David, On Wed, Nov 30, 2016 at 5:35 AM, David Miller wrote: > From: Harini Katakam > Date: Mon, 28 Nov 2016 14:53:49 +0530 > >> In macb_reset_hw, use read-modify-write to disable RX and TX. >> This way exiting settings and reserved bits wont be disturbed. >> Use the same method for clearing s

Re: [PATCH] net: macb: Write only necessary bits in NCR in macb reset

2016-11-29 Thread David Miller
From: Harini Katakam Date: Mon, 28 Nov 2016 14:53:49 +0530 > In macb_reset_hw, use read-modify-write to disable RX and TX. > This way exiting settings and reserved bits wont be disturbed. > Use the same method for clearing statistics as well. > > Signed-off-by: Harini Katakam This doesn't make

[PATCH] net: macb: Write only necessary bits in NCR in macb reset

2016-11-28 Thread Harini Katakam
In macb_reset_hw, use read-modify-write to disable RX and TX. This way exiting settings and reserved bits wont be disturbed. Use the same method for clearing statistics as well. Signed-off-by: Harini Katakam --- drivers/net/ethernet/cadence/macb.c | 9 ++--- 1 file changed, 6 insertions(+),

Re: [PATCH] net: macb: Write only necessary bits in NCR in macb reset

2016-11-28 Thread Harini Katakam
Hi Nicolas, On Mon, Nov 28, 2016 at 3:01 PM, Nicolas Ferre wrote: > Le 28/11/2016 à 10:23, Harini Katakam a écrit : >> In macb_reset_hw, use read-modify-write to disable RX and TX. >> This way exiting settings and reserved bits wont be disturbed. > > Yes, indeed... but I would have liked a line a

Re: [PATCH] net: macb: Write only necessary bits in NCR in macb reset

2016-11-28 Thread Nicolas Ferre
Le 28/11/2016 à 10:23, Harini Katakam a écrit : > In macb_reset_hw, use read-modify-write to disable RX and TX. > This way exiting settings and reserved bits wont be disturbed. Yes, indeed... but I would have liked a line about how you discovered it was an issue for you ; what did it break, etc..