Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-20 Thread Ahmad Fatoum
On 08/15/2018 03:59 PM, Lad, Prabhakar wrote: > This didn’t happen in v4.9.x something in core has changed ? In my case, it was the macb driver that changed. I found the offending commit with git-bisect, you might want to give it a try.

Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-20 Thread Ahmad Fatoum
On 08/16/2018 04:24 PM, Andrew Lunn wrote: > 1) A regression. We should find a fix for that. Maybe we should >special case a child node called 'fixed-link' in >of_mdiobus_register(). I would suggest adding a single warning if >such node is found. I just sent out a v2, which warns if fi

Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-16 Thread Andrew Lunn
On Thu, Aug 16, 2018 at 08:54:40AM +0200, Ahmad Fatoum wrote: > On 08/15/2018 04:32 AM, Andrew Lunn wrote: > > Ahmed, where is the device tree for the EVB-KSZ9477? > > I've attached it [1]. It's still work-in-progress (DSA doesn't work yet for > example), but Ethernet is usable with Linux v4.18 a

Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-15 Thread Ahmad Fatoum
On 08/15/2018 04:32 AM, Andrew Lunn wrote: > Ahmed, where is the device tree for the EVB-KSZ9477? I've attached it [1]. It's still work-in-progress (DSA doesn't work yet for example), but Ethernet is usable with Linux v4.18 and my patch applied. Cheers Ahmad [1] ==

Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-15 Thread Lad, Prabhakar
Hi, On Wed, Aug 15, 2018 at 3:35 AM Andrew Lunn wrote: > > On Tue, Aug 14, 2018 at 05:58:12PM +0200, Uwe Kleine-König wrote: > > Hello Ahmad, > > > > > > On Tue, Aug 14, 2018 at 04:12:40PM +0200, Ahmad Fatoum wrote: > > > The referenced commit broke initializing macb on the EVB-KSZ9477 eval > >

Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-14 Thread Andrew Lunn
On Tue, Aug 14, 2018 at 05:58:12PM +0200, Uwe Kleine-König wrote: > Hello Ahmad, > > > On Tue, Aug 14, 2018 at 04:12:40PM +0200, Ahmad Fatoum wrote: > > The referenced commit broke initializing macb on the EVB-KSZ9477 eval board. > > There, of_mdiobus_register was called even for the fixed-link r

Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-14 Thread Brad Mouring
Hello Ahmed, Uwe, On Tue, Aug 14, 2018 at 05:58:12PM +0200, Uwe Kleine-König wrote: > Hello Ahmad, > > > On Tue, Aug 14, 2018 at 04:12:40PM +0200, Ahmad Fatoum wrote: > > The referenced commit broke initializing macb on the EVB-KSZ9477 eval board. > > There, of_mdiobus_register was called even f

Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-14 Thread Uwe Kleine-König
Hello Ahmad, On Tue, Aug 14, 2018 at 04:12:40PM +0200, Ahmad Fatoum wrote: > The referenced commit broke initializing macb on the EVB-KSZ9477 eval board. > There, of_mdiobus_register was called even for the fixed-link representing > the SPI-connected switch PHY, with the result that the driver at

[PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-14 Thread Ahmad Fatoum
The referenced commit broke initializing macb on the EVB-KSZ9477 eval board. There, of_mdiobus_register was called even for the fixed-link representing the SPI-connected switch PHY, with the result that the driver attempts to enumerate PHYs on a non-existent MDIO bus: libphy: MACB_mii_bus: